Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors
От
Tom Lane
Тема
Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors
Дата
Msg-id
12776.1489160501@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
[HACKERS] Upgrading postmaster's log messages about bind/listen errors Tom Lane <tgl@sss.pgh.pa.us>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listenerrors Joe Conway <mail@joeconway.com>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors Robert Haas <robertmhaas@gmail.com>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors Tom Lane <tgl@sss.pgh.pa.us>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listenerrors "Tels" <nospam-pg-abuse@bloodgate.com>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listenerrors Stephen Frost <sfrost@snowman.net>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors Tom Lane <tgl@sss.pgh.pa.us>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listenerrors Stephen Frost <sfrost@snowman.net>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors Tom Lane <tgl@sss.pgh.pa.us>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors Euler Taveira <euler@timbira.com.br>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors Tom Lane <tgl@sss.pgh.pa.us>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listenerrors Alvaro Herrera <alvherre@2ndquadrant.com>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors Tom Lane <tgl@sss.pgh.pa.us>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors Tom Lane <tgl@sss.pgh.pa.us>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors Tom Lane <tgl@sss.pgh.pa.us>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listenerrors Bruce Momjian <bruce@momjian.us>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listenerrors Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Re: [HACKERS] Upgrading postmaster's log messages about bind/listen errors Craig Ringer <craig@2ndquadrant.com>
Stephen Frost writes: > * Tels (nospam-pg-abuse@bloodgate.com) wrote: >> I'd argue that from a security standpoint it is important to log at >> startup what addresses the service binds to, just so it is visible, >> explicit and logged. > It's also terribly useful for realizing there's an issue. Good points both. > Perhaps we could compromise by simply including the bind information in > the 'ready to accept connections' message, like so: > database system is ready to accept connections on (1.2.3.4) That would be a problem from a couple of directions. First, it wouldn't be unusual for there to be half a dozen addresses to list, not just one. Even a default configuration would probably read like database system is ready to accept connections on (127.0.0.1, ::1, /tmp/.s.PGSQL.5432) which doesn't seem very appetizing to me. Second, it would be considerably messier to implement because the "ready to accept connections" message comes out physically distant from the StreamServerPort function, and we don't save the struct addrinfo list past the end of that function. So I think the logging setup I had in my patch is pretty much the only sane way to do it, and we just have to decide whether it's worth exposing at default log level or not. regards, tom lane
В списке pgsql-hackers по дате отправления
От: Magnus Hagander
Дата: