From: "Fujii Masao" <masao.fujii@gmail.com>
> On Fri, Jan 24, 2014 at 9:00 PM, MauMau <maumau307@gmail.com> wrote:
>> OTOH, regarding PQhost(), I think we had better take my patch.
>> connectOptions2() computes and set derived values to PGconn, so that
>> PGconn's members have values which are actually used for connection. To
>> follow that rule, PGconn->pghost may as well have "localhost" on machines
>> without UNIX domain sockets.
>
> I'm not sure if we should follow that rule. As far as I read the libpq
> code,
> at least connectFailureMessage() and connectDBStart() do the same things
> as PQhost() does now.
Yes, I found them ugly, too. Maybe we can refactor them as a separate
patch.
Regards
MauMau