pgsql: Fix pgstattuple_approx handling of iso-8859-1 tuple estimates
pgsql: Fix pgstattuple_approx handling of iso-8859-1 tuple estimates
От:
Melanie Plageman <melanieplageman@gmail.com>
Дата:
Fix pgstattuple_approx handling of unknown tuple estimates vac_estimate_reltuples() can return -1 when there is not enough information to estimate the number of live tuples. pgstattuple_approx() assigned that value to an unsigned counter before attempting to clamp it, making the clamp ineffective and exposing -1 through the bigint result. Clamp the signed estimate before assigning it to the unsigned counter. Reported-by: Zsolt Parragi Author: Melanie Plageman Reviewed-by: Lukas Fittl Reviewed-by: Zsolt Parragi Discussion: https://postgr.es/m/CAN4CZFM0y8t%2BAQ8PWTeuBXnFtRDUNvkfVzzA_yo6uJ2bceK%3DxA%40mail.gmail.com Backpatch-through: 15 Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/8c15c2cb5c49efcc6fa845f09d7619e0163e3259 Modified Files -------------- contrib/pgstattuple/expected/pgstattuple.out | 12 ++++++++++++ contrib/pgstattuple/pgstatapprox.c | 11 ++++++----- contrib/pgstattuple/sql/pgstattuple.sql | 10 ++++++++++ doc/src/sgml/pgstattuple.sgml | 3 ++- 4 files changed, 30 insertions(+), 6 deletions(-)
Re: pgsql: Fix pgstattuple_approx handling of iso-8859-1 tuple estimates
От:
Melanie Plageman <melanieplageman@gmail.com>
Дата:
On Wed, Nov 18, 2026 at 10:43 AM Melanie Plageman
wrote:
>
> Fix pgstattuple_approx handling of unknown tuple estimates
>
> vac_estimate_reltuples() can return -1 when there is not enough
> information to estimate the number of live tuples. pgstattuple_approx()
> assigned that value to an unsigned counter before attempting to clamp
> it, making the clamp ineffective and exposing -1 through the bigint
> result.
>
> Clamp the signed estimate before assigning it to the unsigned counter.
Looks like I broke the buildfarm with the new test
# @@ -257,11 +257,7 @@
# commit;
# select scanned_percent, approx_tuple_count
# from pgstattuple_approx('test_approx_unknown');
# - scanned_percent | approx_tuple_count
# ------------------+--------------------
# - 0 | 0
# -(1 row)
# -
# +ERROR: cannot access temporary tables during a parallel operation
# -- not for the index calls though, of course
# select pgstatindex('test_partition');
# ERROR: relation "test_partition" is not a btree index
# 1 of 1 tests failed.
Something about debug_parallel_query setting that didn't fail locally.
I will investigate and push a fix.
- Melanie