pgsql: Allow empty arrays of values in pg_restore_attribute_stats()

Поиск
Список
Период
Сортировка
Искать

pgsql: Allow empty arrays of values in pg_restore_attribute_stats()

От:
Michael Paquier <michael@paquier.xyz>
Дата:
Allow empty arrays of values in pg_restore_attribute_stats()

ANALYZE can store an empty array of values for range_length_histogram
and most_common_elems, which pg_dump emits as '{}', since 261f89a976b.
These were rejected by pg_restore_attribute_stats(), as an empty array
has no dimensions, and the statistics were lost after a dump/restore or
an upgrade *from* v19 or HEAD.  Empty arrays are not possible for these
two properties in v18 and older versions.

This commit allows empty arrays for these two cases only.  Arrays stored
as stanumbers are still required to be non-empty, as ANALYZE never
generates them.  get_attstatsslot() fails on them.

Some tests are added to cover both the authorized and non-authorized
patterns, in case somebody has a change of mind in the future regarding
one or more of them.

Reported-by: Atish Prakash <125atishprak@gmail.com>
Author: Corey Huinker 
Author: Michael Paquier 
Discussion: https://postgr.es/m/19857-6e808a09ff4b75d2@postgresql.org
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2656f664616dac41e99495b39e2bc3bc1d81b1e7

Modified Files
--------------
src/backend/statistics/attribute_stats.c   | 10 ++--
src/backend/statistics/stat_utils.c        | 24 ++++++---
src/include/statistics/stat_utils.h        |  3 +-
src/test/regress/expected/stats_import.out | 81 ++++++++++++++++++++++++++++++
src/test/regress/sql/stats_import.sql      | 48 ++++++++++++++++++
5 files changed, 154 insertions(+), 12 deletions(-)

FAQ