pgsql: file_fdw: Fix ANALYZE crashes with DEFAULT markers

Поиск
Список
Период
Сортировка
Искать

pgsql: file_fdw: Fix ANALYZE crashes with DEFAULT markers

От:
Fujii Masao <fujii@postgresql.org>
Дата:
file_fdw: Fix ANALYZE crashes with DEFAULT markers

ANALYZE on a file_fdw foreign table failed an assertion when the input
contained a DEFAULT marker, and could crash in builds without assertions.

This happened because the sampling code passed a NULL ExprContext to
NextCopyFrom(), which requires one to evaluate column defaults.  Fix
this by providing an expression context for sampling, allowing defaults
to be evaluated without assertion failures or crashes.

Backpatch to v16, which introduced DEFAULT marker support.

Author: Fujii Masao 
Reviewed-by: Jim Jones 
Reviewed-by: Ayoub Kazar 
Reviewed-by: Chao Li 
Discussion: https://postgr.es/m/CAHGQGwGwihFV9FmfSbbrMsEr4fti7aHZFkpyMv5-byjfc2EmOw@mail.gmail.com
Backpatch-through: 16

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0b1eb8b917d860ab073c934661530c6b6b23cd63

Modified Files
--------------
contrib/file_fdw/expected/file_fdw.out | 10 ++++++++++
contrib/file_fdw/file_fdw.c            | 24 +++++++++++++-----------
contrib/file_fdw/sql/file_fdw.sql      |  5 +++++
3 files changed, 28 insertions(+), 11 deletions(-)

FAQ