pgsql: ci: Enable PCH in mingw cross job

Поиск
Список
Период
Сортировка
Искать

pgsql: ci: Enable PCH in mingw cross job

От:
Andres Freund <andres@anarazel.de>
Дата:
ci: Enable PCH in mingw cross job

This will make this job run a bit faster.

This backpatches commit 4075409de08 to 19. Since cirrus-ci shut down, only 19
and master have CI, due to the incremental work towards a new CI system. I
soon plan to backpatch CI to all versions that previously had CI. Maintenance
of CI going forward will be simpler if the branches are as similar as
possible.

Co-authored-by: Andres Freund 
Reviewed-by: Nazir Bilal Yavuz 
Discussion: https://www.postgresql.org/message-id/flat/e52e2c29-4834-4c64-a200-eddcba38fb4d%40eisentraut.org
Backpatch-through: 19

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/df7a12749fbe39930be1de871e504325d6e5a5f1
Author: Peter Eisentraut 

Modified Files
--------------
.github/workflows/pg-ci.yml | 3 +++
1 file changed, 3 insertions(+)

Re: pgsql: ci: Enable PCH in mingw cross job

От:
Robert Haas <robertmhaas@gmail.com>
Дата:
On Thu, Nov 5, 2026 at 4:23 PM Andres Freund  wrote:
> ci: Enable PCH in mingw cross job
>
> This will make this job run a bit faster.
>
> This backpatches commit 4075409de08 to 19. Since cirrus-ci shut down, only 19
> and master have CI, due to the incremental work towards a new CI system. I
> soon plan to backpatch CI to all versions that previously had CI. Maintenance
> of CI going forward will be simpler if the branches are as similar as
> possible.
>
> Co-authored-by: Andres Freund 
> Reviewed-by: Nazir Bilal Yavuz 
> Discussion: https://www.postgresql.org/message-id/flat/e52e2c29-4834-4c64-a200-eddcba38fb4d%40eisentraut.org
> Backpatch-through: 19
>
> Branch
> ------
> REL_19_STABLE
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/df7a12749fbe39930be1de871e504325d6e5a5f1
> Author: Peter Eisentraut 

This is pretty weird email formatting. Apparently it happened because
Andres pushed Peter's patch with Peter still listed as the author, but
maybe whatever email script generated this needs updating.

-- 
Robert Haas
Databricks


Re: pgsql: ci: Enable PCH in mingw cross job

От:
Magnus Hagander <magnus@hagander.net>
Дата:
On Fri, 6 Nov 2026 at 18:01, Robert Haas <robertmhaas@gmail.com> wrote:
On Thu, Nov 5, 2026 at 4:23 PM Andres Freund <andres@anarazel.de> wrote:
> ci: Enable PCH in mingw cross job
>
> This will make this job run a bit faster.
>
> This backpatches commit 4075409de08 to 19. Since cirrus-ci shut down, only 19
> and master have CI, due to the incremental work towards a new CI system. I
> soon plan to backpatch CI to all versions that previously had CI. Maintenance
> of CI going forward will be simpler if the branches are as similar as
> possible.
>
> Co-authored-by: Andres Freund <andres@anarazel.de>
> Reviewed-by: Nazir Bilal Yavuz <byavuz81@gmail.com>
> Discussion: https://www.postgresql.org/message-id/flat/e52e2c29-4834-4c64-a200-eddcba38fb4d%40eisentraut.org
> Backpatch-through: 19
>
> Branch
> ------
> REL_19_STABLE
>
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/df7a12749fbe39930be1de871e504325d6e5a5f1
> Author: Peter Eisentraut <peter@eisentraut.org>

This is pretty weird email formatting. Apparently it happened because
Andres pushed Peter's patch with Peter still listed as the author, but
maybe whatever email script generated this needs updating

Yes, the script does indeed add that when author != committer. Since it's the commtter that goes in as "From" on the email.

I'm not sure what you mean needs updating. You want us to not include the author info even if it differs from the committer?
 
--

Re: pgsql: ci: Enable PCH in mingw cross job

От:
Robert Haas <robertmhaas@gmail.com>
Дата:
On Sat, Nov 7, 2026 at 7:02 AM Magnus Hagander  wrote:
> Yes, the script does indeed add that when author != committer. Since it's the commtter that goes in as "From" on the email.
>
> I'm not sure what you mean needs updating. You want us to not include the author info even if it differs from the committer?

Hmm, I don't know, either. It just looked weird. Maybe include both in
that trailer when they differ, to make it a little clearer?

-- 
Robert Haas
Databricks


Re: pgsql: ci: Enable PCH in mingw cross job

От:
Magnus Hagander <magnus@hagander.net>
Дата:
On Mon, 9 Nov 2026 at 12:15, Robert Haas <robertmhaas@gmail.com> wrote:
On Sat, Nov 7, 2026 at 7:02 AM Magnus Hagander <magnus@hagander.net> wrote:
> Yes, the script does indeed add that when author != committer. Since it's the commtter that goes in as "From" on the email.
>
> I'm not sure what you mean needs updating. You want us to not include the author info even if it differs from the committer?

Hmm, I don't know, either. It just looked weird. Maybe include both in
that trailer when they differ, to make it a little clearer?

Do you have a suggestion for how? :)

Should we change "authort" to "Git author" for example? Would that make it more clear in this respect?
 
--
FAQ