pgsql: Fix WAL summary boundary checks for incremental backups.

Поиск
Список
Период
Сортировка
Искать

pgsql: Fix WAL summary boundary checks for incremental backups.

От:
Fujii Masao <fujii@postgresql.org>
Дата:
Fix WAL summary boundary checks for incremental backups.

A standby can summarize received WAL ahead of replay. If recovery ends
exactly where an old-timeline summary begins, FilterWalSummaries()
incorrectly includes that summary even though it covers only WAL outside
the promoted server's history. Truncation information in the summary
can cause an incremental backup to omit modified blocks, leading
pg_combinebackup to reconstruct files with stale data from an earlier
backup. For example, updated rows can revert to their previous values
after restoring the backup.

Fix this by excluding summaries that only touch the boundaries of the
requested LSN range without overlapping it. This makes
FilterWalSummaries() consistent with GetWalSummaries() and its existing
function comments. The old-timeline summary starting at the switch point
is thus excluded, preventing its truncation information from causing
the backup to omit required modified blocks.

Back-patch to PostgreSQL 17, where incremental backup was introduced.

Author: Ayush Tiwari 
Reviewed-by: Chao Li 
Reviewed-by: Manu 
Reviewed-by: Fujii Masao 
Reviewed-by: shihao zhong 
Discussion: https://postgr.es/m/CAJTYsWV7RThdo4K62G8hC=Anpkbr54QWbOvyVvw5uvx4+-x_DQ@mail.gmail.com
Backpatch-through: 17

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5787f8785cb70f3077faba9e7f8421b849c6c19c

Modified Files
--------------
src/backend/backup/walsummary.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

FAQ