pgsql: Fix deparsing of AT TIME ZONE and similar as FROM-clause functio

Поиск
Список
Период
Сортировка
Искать

pgsql: Fix deparsing of AT TIME ZONE and similar as FROM-clause functio

От:
Tom Lane <tgl@sss.pgh.pa.us>
Дата:
Fix deparsing of AT TIME ZONE and similar as FROM-clause functions.

ruleutils.c's looks_like_function() assumed that all COERCE_SQL_SYNTAX
cases produce output that looks like a function call (or at least
like one of the syntaxes the func_expr_windowless production accepts).
But AT TIME ZONE, AT LOCAL, OVERLAPS and IS xxx NORMALIZED print as
other sorts of a_expr, so those cases would produce invalid SQL syntax
when used in a FROM clause.  Extend the logic to detect which specific
functions are safe or unsafe.

Author: Henson Choi 
Reviewed-by: Prashant Chinnam 
Reviewed-by: Tom Lane 
Discussion: https://postgr.es/m/CAAAe_zC68s-DwVX1o7C1HVcRk+Z+RTS6Vw19auZFfz=KaX8tZA@mail.gmail.com
Backpatch-through: 14

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/03fa13256389e5a5d41c76b14a3c9ffd1e45eb35

Modified Files
--------------
src/backend/utils/adt/ruleutils.c         | 55 +++++++++++++++++++++++++++++--
src/test/regress/expected/create_view.out | 33 ++++++++++---------
src/test/regress/sql/create_view.sql      |  3 +-
3 files changed, 72 insertions(+), 19 deletions(-)

FAQ