pgsql: Fix partial two-phase files left by crash during checkpoint

Поиск
Список
Период
Сортировка
Искать

pgsql: Fix partial two-phase files left by crash during checkpoint

От:
Michael Paquier <michael@paquier.xyz>
Дата:
Fix partial two-phase files left by crash during checkpoint

CheckPointTwoPhase() wrote each 2PC file in place, with O_TRUNC.  A
crash mid-write, or a base backup copying the file at that point left an
empty or partial file that would make startup fail, most likely on an
"incorrect size of file" ERROR.

The 2PC files are now written through a temporary file that gets renamed
at the end, relying on the atomicity of the rename to make startup safe,
be it after a crash or a base backup.

Author: Shihao Zhong 
Reviewed-by: Michael Paquier 
Reviewed-by: David Steele 
Discussion: https://postgr.es/m/CAGRkXqS_On-pLgcv6xjH8mvGhdcPmfWtythW3r8pYKUG+hsiuQ@mail.gmail.com
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/606f3db5595dc8459b3d41a081b3ae8ffaae05b9

Modified Files
--------------
src/backend/access/transam/twophase.c | 40 +++++++++++++++++++++++++++++------
1 file changed, 34 insertions(+), 6 deletions(-)

FAQ