pgsql: Remove faulty Asserts added by 1999fe227.

Поиск
Список
Период
Сортировка
Искать

pgsql: Remove faulty Asserts added by 1999fe227.

От:
Tom Lane <tgl@sss.pgh.pa.us>
Дата:
Remove faulty Asserts added by 1999fe227.

I added these assertions in an attempt to show that setting
ret_old_alias/ret_new_alias in set_deparse_plan() fully covered
all the parts of the plan where RETURNING Vars could be found.
But it emerges that the returningOldAlias/returningNewAlias
fields they are filled from can sometimes be NULL themselves,
allowing the asserts to fail.  We discussed various ways that
we might adjust the rewriter to prevent that, but the upshot
of the discussion was just to remove the asserts again.

Reported-by: Ayush Tiwari 
Author: Tom Lane 
Reviewed-by: Dean Rasheed 
Discussion: https://postgr.es/m/CAJTYsWWsORQbyViXmsvT4-NWkjuykkjjk2c+gQtq+vw2PJON-A@mail.gmail.com
Backpatch-through: 18

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/896246ea10cb9d20f69d0442223ce5fa9b365636

Modified Files
--------------
src/backend/utils/adt/ruleutils.c | 6 ------
1 file changed, 6 deletions(-)

FAQ