pgsql: Fix logical replication with lossy identity indexes.

Поиск
Список
Период
Сортировка
Искать

pgsql: Fix logical replication with lossy identity indexes.

От:
Amit Kapila <akapila@postgresql.org>
Дата:
Fix logical replication with lossy identity indexes.

A GiST index on a multirange stores only its bounding range, so different
multiranges can produce the same index key. However,
RelationFindReplTupleByIndex() and RelationFindDeletedTupleInfoByIndex()
assume that matches through a primary key or replica identity index are
exact and skip the equality check. This can cause updates or deletes to
target the wrong row, and conflict detection to report update_deleted
instead of update_missing.

Fix this by rechecking candidates when the index scan sets xs_recheck.
Compare only the index key columns, using the scan keys' equality
operators and collations to match the index's notion of key equality.

Backpatch to 18, where WITHOUT OVERLAPS was introduced. The change to
RelationFindDeletedTupleInfoByIndex() applies only to 19 and later, where
update_deleted conflict detection was added.

Reported-by: Andres Freund 
Author: Paul A. Jungwirth 
Author: Zhijie Hou 
Reviewed-by: Nisha Moond 
Reviewed-by: kedar anavardekar 
Reviewed-by: Amit Kapila 
Discussion: https://postgr.es/m/kcyaok346iwocfdourf2oojgtz7ggxmh2ugis7qqhggs4qfzc2@cu6pkox4rfwp
Discussion: https://postgr.es/m/e5nb5jbus2oa3pffmlo7pdvdckmchd54tqld4k3n6huyg5xxqn@7rounyvufjx6
Discussion: https://postgr.es/m/CA+renyWzTBC4GetPzJM1KqrejrmOWcGnn2NaA7tpee17HFxRPw@mail.gmail.com
Backpatch-through: 18

Branch
------
REL_19_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/48b43081e550f9e4b04e1184ed6d3fed4f850691

Modified Files
--------------
src/backend/executor/execReplication.c   | 66 ++++++++++++++++++++++--
src/test/subscription/t/034_temporal.pl  | 71 ++++++++++++++++++++++++++
src/test/subscription/t/035_conflicts.pl | 86 ++++++++++++++++++++++++++++++++
3 files changed, 219 insertions(+), 4 deletions(-)

FAQ