pgsql: Fix detection of truncated compressed backups

Поиск
Список
Период
Сортировка
Искать

pgsql: Fix detection of truncated compressed backups

От:
Daniel Gustafsson <dgustafsson@postgresql.org>
Дата:
Fix detection of truncated compressed backups

pg_verifybackup failed to detect truncated compressed tar backups
for zstd, lz4 and gzip compression.

astreamer_zstd_decompressor checked whether ZSTD_decompressStream()
returned an error.  However, a positive return value at end-of-input
means that the final zstd frame has not completed.  Record the state
and verify at finalization that zstd completed the frame.  Also flush
any pending internally buffered output before performing that check.

astreamer_gzip_decompressor did not check whether inflate() had
reached Z_STREAM_END before finalizing.  Record whether inflate()
completed the gzip stream, and reject finalization if it did not.

astreamer_lz4_decompressor did not check whether LZ4F_decompress()
completed the final frame before finalizing.  Record the status of
decompression and reject finalization unless the frame completed.

This prevents pg_verifybackup from accepting a truncated compressed
tar backup.

Author: Chao Li 
Co-authored-by: Daniel Gustafsson 
Reviewed-by: Osama Abdul Qader 
Reviewed-by: Zsolt Parragi 
Reviewed-by: Japin Li 
Discussion: https://postgr.es/m/5962B878-C43D-4EBC-9E95-1F945CE5E586@gmail.com
Backpatch-through: 19

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e41b01f4359d3256943c00c834a3d9abef6c0129

Modified Files
--------------
src/bin/pg_verifybackup/t/010_client_untar.pl | 13 ++++++++
src/fe_utils/astreamer_gzip.c                 | 13 +++++++-
src/fe_utils/astreamer_lz4.c                  | 13 ++++++++
src/fe_utils/astreamer_zstd.c                 | 46 +++++++++++++++++++++++++++
src/include/fe_utils/astreamer.h              | 14 ++++++++
src/tools/pgindent/typedefs.list              |  1 +
6 files changed, 99 insertions(+), 1 deletion(-)

FAQ