pgsql: Fix parallel vacuum I/O timing reporting.

Поиск
Список
Период
Сортировка
Искать

pgsql: Fix parallel vacuum I/O timing reporting.

От:
Masahiko Sawada <msawada@postgresql.org>
Дата:
Fix parallel vacuum I/O timing reporting.

Commit 5cd72cc0c5 made the VACUUM VERBOSE and autovacuum logs report
buffer usage from the pgBufferUsage delta, which includes the parallel
workers' usage, but left the I/O timings on the leader's
pgStatBlockReadTime and pgStatBlockWriteTime. So the log counted the
blocks the workers read and dirtied but not the time they spent on
them.

Fix this by taking the I/O timings from the same BufferUsage delta.
This also removes a small error in the leader's own timings, since
pgStatBlock{Read,Write}Time accumulate whole microseconds per I/O.

Although 5cd72cc0c5 was backpatched to v15, BufferUsage on v16 doesn't
track the I/O time of temporary relations, so the same fix there would
drop that time from the log. We don't think a reporting issue is worth
v16-specific code, nor worth leaving v16 unfixed between v15 and v17,
so backpatch to v17 only.

Found by Bharath using AI assisted review with Claude.

Reported-by: Bharath Rupireddy 
Author: Bharath Rupireddy 
Reviewed-by: Sami Imseih 
Reviewed-by: Chao Li 
Reviewed-by: Masahiko Sawada 
Reviewed-by: Shihao Zhong 
Discussion: https://postgr.es/m/CALj2ACXrqaHrYmGdpAoGKXtiY9Xw4o1dxSC+EELxn47GDO6HAQ@mail.gmail.com
Backpatch-through: 17

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/abf5fec634f6aac98e80e2ef6c3f3dbf0133dfaa

Modified Files
--------------
src/backend/access/heap/vacuumlazy.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)

FAQ