pgsql: Fix RLS checks for FOR PORTION OF leftover rows

Поиск
Список
Период
Сортировка
Искать

pgsql: Fix RLS checks for FOR PORTION OF leftover rows

От:
Peter Eisentraut <peter@eisentraut.org>
Дата:
Fix RLS checks for FOR PORTION OF leftover rows

UPDATE/DELETE FOR PORTION OF may insert leftover rows to preserve the
parts of the old row that are outside the target range.  Those inserts
go through ExecInsert(), which checks RLS policies using
WCO_RLS_INSERT_CHECK.

However, the rewriter only added RLS WITH CHECK options for the
original statement command.  For UPDATE, that meant only
WCO_RLS_UPDATE_CHECK options were available, so ExecInsert() skipped
them.  For DELETE, no RLS WITH CHECK options were added at all.  As a
result, leftover rows could be inserted even when they violated INSERT
RLS policies.

Fix this by adding INSERT RLS WITH CHECK options for UPDATE/DELETE FOR
PORTION OF target relations.  Also add regression coverage for both
UPDATE and DELETE, including cases where allowed leftovers still
succeed and disallowed leftovers are rejected.

Author: Chao Li 
Co-authored-by: Paul A Jungwirth 
Reviewed-by: Paul A Jungwirth 
Reviewed-by: Ayush Tiwari 
Reviewed-by: Dean Rasheed 
Discussion: https://www.postgresql.org/message-id/flat/6C34A987-AC50-4477-BD71-2D4AFEE1A589%40gmail.com
Discussion: https://www.postgresql.org/message-id/flat/CAJTYsWWdeBkoH5g8D-k9LDw9ciqsMxb21EJSiFXAzP4J%3DXyxOQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/20fe90bbb93df755e00dc88ace5988fda0b1d7d3

Modified Files
--------------
doc/src/sgml/ref/create_policy.sgml          | 32 ++++++++++++
doc/src/sgml/ref/delete.sgml                 |  3 +-
doc/src/sgml/ref/update.sgml                 |  3 +-
src/backend/rewrite/rowsecurity.c            | 25 ++++++++++
src/test/regress/expected/for_portion_of.out | 75 ++++++++++++++++++++++++++++
src/test/regress/expected/rowsecurity.out    | 39 ++++++++++++++-
src/test/regress/sql/for_portion_of.sql      | 58 +++++++++++++++++++++
src/test/regress/sql/rowsecurity.sql         | 33 +++++++++++-
8 files changed, 264 insertions(+), 4 deletions(-)

FAQ