pgsql: Make GetSnapshotData() more resilient on out-of-memory errors
pgsql: Make GetSnapshotData() more resilient on out-of-memory errors
От:
Michael Paquier <michael@paquier.xyz>
Дата:
Make GetSnapshotData() more resilient on out-of-memory errors If the allocation of Snapshot->subxip fails, a follow-up call of GetSnapshotData() would see a partially-initialized snapshot, causing a NULL dereference on reentry when using "subxip" because only "xip" would be allocated. In the event of an out-of-memory error when allocating "subxip", "xip" is now reset before throwing an ERROR, so as Snapshots can be allocated and handled gracefully on retry. This problem is unlikely going to show up in practice, so no backpatch. Reported-by: Alexander Lakhin Author: Matthias van de Meent Discussion: https://postgr.es/m/e77acaac-a1b3-40b3-99ee-5769b4e453e4@gmail.com Branch ------ master Details ------- https://git.postgresql.org/pg/commitdiff/29fb598b9cad898ef851b9a7704f980218057562 Modified Files -------------- src/backend/storage/ipc/procarray.c | 8 ++++++++ 1 file changed, 8 insertions(+)
Re: pgsql: Make GetSnapshotData() more resilient on out-of-memory errors
От:
Aleksander Alekseev <aleksander@tigerdata.com>
Дата:
Hi Michael, > This problem is unlikely going to show up in practice, so no backpatch. A customer reported offlist that the issue is reproducible in practice on PostgreSQL 18. I suggest backpatching this. -- Best regards, Aleksander Alekseev