Re: Dead reference to schema_only_with_statistics in pg_dump TAP code
Re: Dead reference to schema_only_with_statistics in pg_dump TAP code
От:
Michael Paquier <michael@paquier.xyz>
Дата:
On Mon, Jun 15, 2026 at 06:04:59PM +0800, Ewan Young wrote: > LGTM, and +1 for including v18 to keep future back-patches quiet. Ok, thanks. Applied now as I have been playing with this area of the code. -- Michael
Re: Dead reference to schema_only_with_statistics in pg_dump TAP code
От:
Ewan Young <kdbase.hack@gmail.com>
Дата:
Hi Michael, Confirmed here. The schema_only_with_statistics run definition was removed in 0ed92cf50cc4 (when --schema-only + --with-statistics became a rejected combination), but the references left behind in %full_runs and in the per-test like/unlike lists were never cleaned up. Since the main loop only iterates over keys %pgdump_runs, those leftover keys are never looked up, so they've simply been inert. LGTM, and +1 for including v18 to keep future back-patches quiet. Thanks, Ewan On Mon, Jun 15, 2026 at 4:07 PM Michael Paquier wrote: > > Hi all, > > While looking at the TAP tests of pg_dump today, I have bumped into a > dead reference to a command sequence named schema_only_with_statistics. > This reference has been removed in 0ed92cf50cc4, and has been listed a > couple of times after that, having no effect. > > Let's clean up that as of the attached on HEAD, at least. v18 would > be nice to include in the set, as this script is already complicated > and that could create noise when backpatching. > > Comments or opinions? > -- > Michael
pgsql: Obstruct EXTRACT() field name deparse injection.
От:
Noah Misch <noah@leadboat.com>
Дата:
Obstruct EXTRACT() field name deparse injection. The parser accepts any string as an EXTRACT() field name, but deparsing does not quote and escape it accordingly. To fix, quote and escape the field name during deparsing as needed. It might be a good idea to validate the field name during parsing and deparsing, too, but that is left as a future exercise. Reported-by: Ben Morris in collaboration with Claude and Anthropic Research Author: Nathan Bossart Reviewed-by: Tom Lane Reviewed-by: Etsuro Fujita Security: CVE-2026-15741 Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/5981fe370a0d433429977ff6fc420064cf2fa09a Author: Nathan Bossart Modified Files -------------- src/backend/utils/adt/ruleutils.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
