pgsql: Improve overflow/underflow handling in regr_intercept().

Поиск
Список
Период
Сортировка
Искать

pgsql: Improve overflow/underflow handling in regr_intercept().

От:
Dean Rasheed <dean.a.rasheed@gmail.com>
Дата:
Improve overflow/underflow handling in regr_intercept().

As with corr() and regr_r2(), improve regr_intercept()'s final
function to cope with overflow/underflow in the final calculation.
Here, instead of using sqrt(), we use frexp() and ldexp() to recover,
if an overflow or underflow is detected, so that the multiplication
and division steps operate on normalised mantissas, and cannot
overflow or underflow.

As with 6498287696d, and the previous commit improving regr_r2(), this
is arguably a bug fix, but given the lack of prior complaints, refrain
from back-patching.

Reported-by: Tom Lane 
Author: Dean Rasheed 
Reviewed-by: Chengpeng Yan 
Discussion: https://postgr.es/m/33E01656-BB3B-46E9-A41F-24A01A7C35F4@outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/eb8e76e130fd8bd42982d597f5a66f08b13380c0

Modified Files
--------------
src/backend/utils/adt/float.c            | 39 ++++++++++++++++++++++++++++++--
src/test/regress/expected/aggregates.out | 12 ++++++++++
src/test/regress/sql/aggregates.sql      |  2 ++
3 files changed, 51 insertions(+), 2 deletions(-)

FAQ