Re: Improve errmsg for publication membership
Re: Improve errmsg for publication membership
От:
Ewan Young <kdbase.hack@gmail.com>
Дата:
On Wed, Jun 3, 2026 at 1:10 PM Peter Smith wrote:
>
> Here is a patch to reword 2 publication error messages:
>
> BEFORE/AFTER
> "relation \"%s\" is already member of publication \"%s\"",
> "relation \"%s\" is already a member of publication \"%s\"",
>
> BEFORE/AFTER
> "schema \"%s\" is already member of publication \"%s\"",
> "schema \"%s\" is already a member of publication \"%s\"",
>
> ~~~
>
> All other 'member of' error messages in PostgreSQL source are using
> correct grammar ('a member of'), so IMO these should do likewise.
>
> PSA v1.
Thanks. Patch applies cleanly on master, the wording fix matches all other
'member of' messages in the tree, and make check passes (245/245). LGTM.
Regards,
Ewan
>
> ======
> Kind Regards,
> Peter Smith.
> Fujitsu Australia
Re: Improve errmsg for publication membership
От:
Amit Kapila <amit.kapila16@gmail.com>
Дата:
On Wed, Jun 3, 2026 at 11:35 AM Ewan Young wrote:
>
> On Wed, Jun 3, 2026 at 1:10 PM Peter Smith wrote:
> >
> > Here is a patch to reword 2 publication error messages:
> >
> > BEFORE/AFTER
> > "relation \"%s\" is already member of publication \"%s\"",
> > "relation \"%s\" is already a member of publication \"%s\"",
> >
> > BEFORE/AFTER
> > "schema \"%s\" is already member of publication \"%s\"",
> > "schema \"%s\" is already a member of publication \"%s\"",
> >
> > ~~~
> >
> > All other 'member of' error messages in PostgreSQL source are using
> > correct grammar ('a member of'), so IMO these should do likewise.
> >
> > PSA v1.
>
> Thanks. Patch applies cleanly on master, the wording fix matches all other
> 'member of' messages in the tree, and make check passes (245/245). LGTM.
>
LGTM as well. I think it is a minor inconsistency and we should fix it
only in HEAD. If so, we can probably wait for the PG20 branch to open
as this is not newly introduced in PG19.
--
With Regards,
Amit Kapila.
pgsql: Fix missing space before WHERE in GRAPH_TABLE deparse
Fix missing space before WHERE in GRAPH_TABLE deparse get_graph_pattern_def() emitted the pattern-level WHERE keyword as "WHERE " with no leading space, so reverse-parsing produced output like "(o IS orders)WHERE (...)". The element-level WHERE deparse in get_path_pattern_expr_def() already prepends a separating space; the pattern-level branch was inconsistent with it. Emit " WHERE " to match. The output still re-parses to the same tree, so this is cosmetic. For test coverage, add a whole-pattern WHERE clause to the existing customers_us view, which is already reverse-parsed with pg_get_viewdef(). Author: Dhruv Chauhan Reviewed-by: Ashutosh Bapat Discussion: https://www.postgresql.org/message-id/flat/CANWwWcpHb0h7tg6otRnL-FV83jwQpAiyw1bhvv8T78kpwZ-0ow%40mail.gmail.com Branch ------ REL_19_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/d2ac26eb9b1e8ad19fd526efb0ffff4fae5ed56f Modified Files -------------- src/backend/utils/adt/ruleutils.c | 2 +- src/test/regress/expected/graph_table.out | 21 +++++++++++---------- src/test/regress/sql/graph_table.sql | 5 +++-- 3 files changed, 15 insertions(+), 13 deletions(-)
Re: Improve errmsg for publication membership
От:
Peter Smith <smithpb2250@gmail.com>
Дата:
On Mon, Aug 10, 2026 at 4:52 PM Daniel Gustafsson wrote: > > > On 10 Aug 2026, at 08:15, Peter Smith wrote: > > > I also think it only needs to be fixed in HEAD. And, the PG20 branch > > started ages ago, so AFAIK there are no blockers for this patch > > anymore. > > Maybe not ages ago (~6 weeks) but agreed that this can go master only, patch > pushed. > Thanks for pushing! I've marked the CF entry as "committed". ====== Kind Regards, Peter Smith. Fujitsu Australia