Re: postgres_fdw, dblink: Validate use_scram_passthrough values
Re: postgres_fdw, dblink: Validate use_scram_passthrough values
От:
Matheus Alcantara <matheusssilv97@gmail.com>
Дата:
On 27/05/26 11:41, Fujii Masao wrote: > Hi, > > The use_scram_passthrough option in postgres_fdw and dblink is > intended to accept only boolean values. However, unlike other boolean > options such as keep_connections, its value is not currently > validated. > > As a result, invalid values are accepted unexpectedly, for example: > > CREATE SERVER test_server > FOREIGN DATA WRAPPER postgres_fdw > OPTIONS (use_scram_passthrough 'invalid'); > > Attached patch updates postgres_fdw and dblink to validate > use_scram_passthrough values and throw an error for invalid input. > Hi, Thank you for the patch. It looks correct to me and it fix the issue as mentioned. -- Matheus Alcantara EDB: https://www.enterprisedb.com
Re: postgres_fdw, dblink: Validate use_scram_passthrough values
От:
Fujii Masao <masao.fujii@gmail.com>
Дата:
On Thu, May 28, 2026 at 3:22 AM Matheus Alcantara wrote: > Thank you for the patch. It looks correct to me and it fix the issue > as mentioned. Thank Ayush and Matheus for the review! I've pushed the patch. Regards, -- Fujii Masao
pgsql: Restore vacuum_delay_point() in GIN posting-tree leaf vacuum
Restore vacuum_delay_point() in GIN posting-tree leaf vacuum Commit fd83c83d094 turned the recursive posting-tree cleanup in ginVacuumPostingTreeLeaves() into an iterative sweep that follows the tree's leaf pages via their rightlinks. The recursive version called vacuum_delay_point() while processing the tree, but that call was removed and never re-added to the new loop. As that commit only set out to fix a deadlock, the removal appears to have been unintentional. Consequently the leaf-page sweep of a single posting tree runs with no vacuum_delay_point(), and therefore no CHECK_FOR_INTERRUPTS(). A posting tree stores all the TIDs for one indexed key, so for a frequently occurring key it can span a large number of leaf pages. While such a tree is being vacuumed the operation ignores vacuum_cost_delay and does not respond to query cancellation or statement_timeout; an autovacuum worker likewise cannot be interrupted mid-sweep when another backend requests a conflicting lock. Restore the call, placed after the current page has been unlocked and released so that no buffer content lock is held across a potential delay (cf. 21c27af65fb). The sibling loops in ginbulkdelete() and ginvacuumcleanup() already call vacuum_delay_point() once per page. Author: Paul Kim Co-authored-by: Alexander Korotkov Reviewed-by: Michael Paquier Reviewed-by: Andrey Borodin Reviewed-by: solai v Discussion: https://postgr.es/m/178447127453.110.12276981925360691905%40mail.gmail.com Backpatch-through: 14 Branch ------ REL_17_STABLE Details ------- https://git.postgresql.org/pg/commitdiff/ba5e4632959027d34ec0254e1597315c3fea4c1e Modified Files -------------- src/backend/access/gin/ginvacuum.c | 7 +++++++ 1 file changed, 7 insertions(+)