Обсуждение: pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl

Поиск
Список
Период
Сортировка

pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl

От
Mahendra Singh Thalor
Дата:
Hi,

While doing some changes, I found a typo error(wrong word) in 001_basic.pl file.
   
In 31a8b77a9244a0883e1968adc, we added some test cases for pg_dump, pg_restore and pg_dumpall.
In one error case, we added  'pg_dump' name instead of 'pg_rsetore'.

diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.pl
index 9f12ca6c51d..ff1d422292e 100644
--- a/src/bin/pg_dump/t/001_basic.pl
+++ b/src/bin/pg_dump/t/001_basic.pl
@@ -144,7 +144,7 @@ command_fails_like(
 command_fails_like(
        [ 'pg_restore', '-f -', '-F', 'garbage' ],
        qr/\Qpg_restore: error: unrecognized archive format "garbage";\E/,
-       'pg_dump: unrecognized archive format');
+       'pg_restore: unrecognized archive format');
 
Here, I am attaching a patch to fix this.This patch can be applied till PG14.

I think we should back-patch till PG14. Please review this.

--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
Вложения

Re: pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl

От
Michael Paquier
Дата:
On Sun, Mar 15, 2026 at 10:59:53PM +0530, Mahendra Singh Thalor wrote:
> I think we should back-patch till PG14. Please review this.

Thanks, grabbed this one for later.  I am not sure if it is worth
bothering about the back-branches.  If somebody feels otherwise,
please feel free to overwrite me and I will adapt.
--
Michael

Вложения