Обсуждение: New isolation test insert-conflict-do-update-4 outputs rows in alternative ordering

Hi, hackers!

New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2

Unlike the previous test (insert-conflict-do-update-3) it doesn't
contain an ordering clause, and when run on a table with a custom
access method, it outputs results in a reverse order.

It's a very minor issue, and the proposed fix is just adding the
missing ORDER BY clause.

Other insert-conflict-do-* isolation tests output just one row except
the mentioned insert-conflict-do-update-3 and
insert-conflict-do-update-4.

The patch is attached

Kind regards,
Pavel Borisov
Supabase

This fix should also be backported to all releases that have commit
4b760a181ab2 backported.

Pavel Borisov

On Tue, 24 Feb 2026 at 20:13, Pavel Borisov <pashkin.elfe@gmail.com> wrote:
>
> Hi, hackers!
>
> New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2
>
> Unlike the previous test (insert-conflict-do-update-3) it doesn't
> contain an ordering clause, and when run on a table with a custom
> access method, it outputs results in a reverse order.
>
> It's a very minor issue, and the proposed fix is just adding the
> missing ORDER BY clause.
>
> Other insert-conflict-do-* isolation tests output just one row except
> the mentioned insert-conflict-do-update-3 and
> insert-conflict-do-update-4.
>
> The patch is attached
>
> Kind regards,
> Pavel Borisov
> Supabase

Pavel Borisov <pashkin.elfe@gmail.com> writes:
> New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2
> Unlike the previous test (insert-conflict-do-update-3) it doesn't
> contain an ordering clause, and when run on a table with a custom
> access method, it outputs results in a reverse order.
> It's a very minor issue, and the proposed fix is just adding the
> missing ORDER BY clause.

Right, done.

            regards, tom lane

On Wed, 25 Feb 2026 at 19:52, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Pavel Borisov <pashkin.elfe@gmail.com> writes:
> > New isolation test insert-conflict-do-update-4 was added by commit 4b760a181ab2
> > Unlike the previous test (insert-conflict-do-update-3) it doesn't
> > contain an ordering clause, and when run on a table with a custom
> > access method, it outputs results in a reverse order.
> > It's a very minor issue, and the proposed fix is just adding the
> > missing ORDER BY clause.
>
> Right, done.
>
>                         regards, tom lane
Thank you!
Regards,
Pavel Borisov