Обсуждение: DOCS - pg_walsummary typo?

Поиск
Список
Период
Сортировка

DOCS - pg_walsummary typo?

От
Peter Smith
Дата:
Hi.

I found what seems to be a typo in the pg_walsummary description. I
guess that "with" was supposed to say "within", but IMO just "in" is
fine.

BEFORE
These binary files are found with the pg_wal/summaries subdirectory of
the data directory...

SUGGESTION
These binary files are found in the pg_wal/summaries subdirectory of
the data directory...


PSA patch for the same.

======
Kind Regards,
Peter Smith.
Fujitsu Australia.

Вложения

Re: DOCS - pg_walsummary typo?

От
Robert Treat
Дата:
On Sun, Feb 15, 2026 at 10:40 PM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi.
>
> I found what seems to be a typo in the pg_walsummary description. I
> guess that "with" was supposed to say "within", but IMO just "in" is
> fine.
>
> BEFORE
> These binary files are found with the pg_wal/summaries subdirectory of
> the data directory...
>
> SUGGESTION
> These binary files are found in the pg_wal/summaries subdirectory of
> the data directory...
>
>
> PSA patch for the same.

+1

Robert Treat
https://xzilla.net



Re: DOCS - pg_walsummary typo?

От
Chao Li
Дата:

> On Feb 16, 2026, at 11:39, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi.
>
> I found what seems to be a typo in the pg_walsummary description. I
> guess that "with" was supposed to say "within", but IMO just "in" is
> fine.
>
> BEFORE
> These binary files are found with the pg_wal/summaries subdirectory of
> the data directory...
>
> SUGGESTION
> These binary files are found in the pg_wal/summaries subdirectory of
> the data directory...
>
>
> PSA patch for the same.
>
> ======
> Kind Regards,
> Peter Smith.
> Fujitsu Australia.
> <v1-0001-DOCS-pg_walsummary-fix-typo.patch>

I would guess “with” was a typo of “within”. I agree with changing “with” to “in”, alternatively, “within” and “under”
mayalso work there. 

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







Re: DOCS - pg_walsummary typo?

От
Michael Paquier
Дата:
On Mon, Feb 16, 2026 at 08:13:26AM -0500, Robert Treat wrote:
> On Sun, Feb 15, 2026 at 10:40 PM Peter Smith <smithpb2250@gmail.com> wrote:
>> I found what seems to be a typo in the pg_walsummary description. I
>> guess that "with" was supposed to say "within", but IMO just "in" is
>> fine.
>
> +1

Yep, the wording seems strange and switching this single word is an
improvement.  Will fix later, if there are no objections.
--
Michael

Вложения

Re: DOCS - pg_walsummary typo?

От
Michael Paquier
Дата:
On Mon, Mar 02, 2026 at 04:17:23PM +0900, Michael Paquier wrote:
> Yep, the wording seems strange and switching this single word is an
> improvement.  Will fix later, if there are no objections.

Done.
--
Michael

Вложения

Re: DOCS - pg_walsummary typo?

От
Peter Smith
Дата:
Thanks for pushing!

I have marked the corresponding CF entry as "Committed".

======
Kind Regards,
Peter Smith.
Fujitsu Australia.