Обсуждение: Fix wrong log in pgstat_report_checksum_failures_in_db()

Hi hackers,

The function pgstat_report_checksum_failures_in_db(), file 
pgstat_database.c,
currently emits a log message referring to "conflicts", which seems wrong.
As the function name suggesting, the log message should refer to 
"checksum failures".


Best regards,
Wang Peng

On Wed, Feb 11, 2026 at 05:22:27PM +0800, wangpeng wrote:
> The function pgstat_report_checksum_failures_in_db(), file
> pgstat_database.c,
> currently emits a log message referring to "conflicts", which seems wrong.
> As the function name suggesting, the log message should refer to "checksum
> failures".

Right, that's strange.  It looks like a copy-pasto, but I am not sure
from where.

> -        elog(WARNING, "could not report %d conflicts for DB %u",
> +        elog(WARNING, "could not report %d checksum failures for DB %u",
>               failurecount, dboid);

We may as well use "for database" here.  Let's improve it a bit more
while on it, even if it is not translated.
--
Michael

Michael Paquier 写于 2026/2/11 19:06:
> On Wed, Feb 11, 2026 at 05:22:27PM +0800, wangpeng wrote:
> > The function pgstat_report_checksum_failures_in_db(), file
> > pgstat_database.c,
> > currently emits a log message referring to "conflicts", which seems wrong.
> > As the function name suggesting, the log message should refer to "checksum
> > failures".
>
> Right, that's strange.  It looks like a copy-pasto, but I am not sure
> from where.
>
> > -        elog(WARNING, "could not report %d conflicts for DB %u",
> > +        elog(WARNING, "could not report %d checksum failures for DB %u",
> >               failurecount, dboid);
>
> We may as well use "for database" here.  Let's improve it a bit more
> while on it, even if it is not translated.
> --
> Michael

Thanks for your review. Updated "for DB" to "for database" in v2.

Best regards,
Wang Peng

On Thu, Feb 12, 2026 at 08:59:13AM +0800, wangpeng wrote:
> Thanks for your review. Updated "for DB" to "for database" in v2.

Thanks.  Applied that now down to v18.
--
Michael