Обсуждение: pgsql: pg_recvlogical: remove unnecessary OutputFsync() return value ch

Поиск
Список
Период
Сортировка

pgsql: pg_recvlogical: remove unnecessary OutputFsync() return value ch

От
Fujii Masao
Дата:
pg_recvlogical: remove unnecessary OutputFsync() return value checks.

Commit 1e2fddfa33d changed OutputFsync() so that it always returns true.
However, pg_recvlogical.c still contained checks of its boolean return
value, which are now redundant.

This commit removes those checks and changes the type of return value of
OutputFsync() to void, simplifying the code.

Suggested-by: Yilin Zhang <jiezhilove@126.com>
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: Mircea Cadariu <cadariu.mircea@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://postgr.es/m/CAHGQGwFeTymZQ7RLvMU6WuDGar8bUQCazg=VOfA-9GeBkg-FzA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b98cc4a14e538d0bc139f50606249b99cc9215cd

Modified Files
--------------
src/bin/pg_basebackup/pg_recvlogical.c | 23 +++++++----------------
1 file changed, 7 insertions(+), 16 deletions(-)