Обсуждение: [PATCH] Fix typo in pgstat_replslot.c

Поиск
Список
Период
Сортировка

[PATCH] Fix typo in pgstat_replslot.c

От
"zengman"
Дата:
Hi,

I noticed this could be corrected to `exists` (instead of `exits`) here, same as commit
63ed3bc7f9a66035e0b741aaa542de35a90fe1cc.
```c
    /* Check if the slot exits with the given name. */
    slot = SearchNamedReplicationSlot(name, false);

    if (!slot)
        ereport(ERROR,
                (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
                 errmsg("replication slot \"%s\" does not exist",
                        name)));
```

--
Regards,
Man Zeng
www.openhalo.org
Вложения

Re: [PATCH] Fix typo in pgstat_replslot.c

От
Amit Kapila
Дата:
On Wed, Jan 7, 2026 at 4:52 PM zengman <zengman@halodbtech.com> wrote:
>
> I noticed this could be corrected to `exists` (instead of `exits`) here, same as commit
63ed3bc7f9a66035e0b741aaa542de35a90fe1cc.
> ```c
>         /* Check if the slot exits with the given name. */
>         slot = SearchNamedReplicationSlot(name, false);
>
>         if (!slot)
>                 ereport(ERROR,
>                                 (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>                                  errmsg("replication slot \"%s\" does not exist",
>                                                 name)));
> ```
>

oops, we should have caught it last time along with commit
63ed3bc7f9a66035e0b741aaa542de35a90fe1cc but anyway I checked there is
no more similar typo in the code. So, the patch LGTM.

--
With Regards,
Amit Kapila.



Re: [PATCH] Fix typo in pgstat_replslot.c

От
"zengman"
Дата:
> oops, we should have caught it last time along with commit
> 63ed3bc7f9a66035e0b741aaa542de35a90fe1cc but anyway I checked there is
> no more similar typo in the code. So, the patch LGTM.

Hi Mr. Amit, 

Thank you for confirming. I also couldn't find a similar error.

--
Regards,
Man Zeng
www.openhalo.org