Обсуждение: [PATCH] tests: verify renamed index functionality in alter_table

 

The alter_table test has a FIXME saying the index rename test should verify the index still works afterward. Currently it only checks that ALTER INDEX RENAME succeeds, not that the renamed index is usable.

-- ALTER TABLE ... RENAME on non-table relations

-- renaming indexes (FIXME: this should probably test the index's functionality)

This patch adds a simple verification: EXPLAIN to show the planner finds the index, and a SELECT to confirm it returns correct data. Uses the standard enable_seqscan/bitmapscan/indexonlyscan=off pattern to force a stable Index Scan across environments.

Test-only change. Verified with:
- make check TESTS=alter_table  # passes
- make check  # all 236 tests pass

Thanks,
Dharin

Hi Dharin,

Thanks for addressing the FIXME in the alter_table regression test.

The change LGTM. Verifying both planner visibility via EXPLAIN and runtime correctness with a SELECT after the index rename is a solid improvement, and using the standard enable_seqscan/bitmapscan/indexonlyscan = off pattern keeps the test deterministic.

I tested the patch locally and it passes:

make check TESTS=alter_table

full make check

O/P: ok 206       + alter_table                               870 ms

I don’t see any issues with the approach.

Regards,
Vasuki M,
C-DAC,Chennai

Hi Dharin,

Thank you for the patch.

I reviewed your patch and the changes look good.

I applied your patch and all the tests pass.

Regards,

Surya Poondla

Dharin