Обсуждение: Copy script button cleanup
The Copy Script buttons on the Linux package installation pages look horrific. See before.png.
The attached patch makes them look much nicer, with proper sizing and an icon based button. On click, it briefly changes to a green checkmark to show confirmation. See the after screenshots.
I'll apply this in a couple of days if there are no objections.
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
Вложения
On Tue, 2 Dec 2025 at 12:30, Dave Page <dpage@pgadmin.org> wrote:
The Copy Script buttons on the Linux package installation pages look horrific. See before.png.The attached patch makes them look much nicer, with proper sizing and an icon based button. On click, it briefly changes to a green checkmark to show confirmation. See the after screenshots.I'll apply this in a couple of days if there are no objections.
LGTM in general and certainly is a lot prettier.
Can you explain what that "fallback for text based buttons" is? Aren't they all replaced with icons?
Oh, and I'm told you're not supposed to use "var" for variables in js due to the broken scoping :)
And while you're poking at it, one thing I've really wanted is a "copy without the sudo parts". But I'm guessing that would be a lot more complicated than what you're fixing here...
On Tue, 2 Dec 2025 at 14:41, Magnus Hagander <magnus@hagander.net> wrote:
On Tue, 2 Dec 2025 at 12:30, Dave Page <dpage@pgadmin.org> wrote:The Copy Script buttons on the Linux package installation pages look horrific. See before.png.The attached patch makes them look much nicer, with proper sizing and an icon based button. On click, it briefly changes to a green checkmark to show confirmation. See the after screenshots.I'll apply this in a couple of days if there are no objections.LGTM in general and certainly is a lot prettier.Can you explain what that "fallback for text based buttons" is? Aren't they all replaced with icons?
Oh, yeah. That's no longer needed now the patch is complete. I'll remove it.
Oh, and I'm told you're not supposed to use "var" for variables in js due to the broken scoping :)
Old habits die hard :-(
And while you're poking at it, one thing I've really wanted is a "copy without the sudo parts". But I'm guessing that would be a lot more complicated than what you're fixing here...
Ask and thou shalt receive.
2 patches attached. Both fix the original issue. One also adds the no sudo button.
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
Вложения
On 2 Dec 2025, at 15:41, Magnus Hagander <magnus@hagander.net> wrote:On Tue, 2 Dec 2025 at 12:30, Dave Page <dpage@pgadmin.org> wrote:The Copy Script buttons on the Linux package installation pages look horrific. See before.png.The attached patch makes them look much nicer, with proper sizing and an icon based button. On click, it briefly changes to a green checkmark to show confirmation. See the after screenshots.I'll apply this in a couple of days if there are no objections.LGTM in general and certainly is a lot prettier.
+1, it looks much better!
--
Daniel Gustafsson
Daniel Gustafsson
On Wed, 3 Dec 2025 at 11:38, Dave Page <dpage@pgadmin.org> wrote:
On Tue, 2 Dec 2025 at 14:41, Magnus Hagander <magnus@hagander.net> wrote:On Tue, 2 Dec 2025 at 12:30, Dave Page <dpage@pgadmin.org> wrote:The Copy Script buttons on the Linux package installation pages look horrific. See before.png.The attached patch makes them look much nicer, with proper sizing and an icon based button. On click, it briefly changes to a green checkmark to show confirmation. See the after screenshots.I'll apply this in a couple of days if there are no objections.LGTM in general and certainly is a lot prettier.Can you explain what that "fallback for text based buttons" is? Aren't they all replaced with icons?Oh, yeah. That's no longer needed now the patch is complete. I'll remove it.Oh, and I'm told you're not supposed to use "var" for variables in js due to the broken scoping :)Old habits die hard :-(And while you're poking at it, one thing I've really wanted is a "copy without the sudo parts". But I'm guessing that would be a lot more complicated than what you're fixing here...Ask and thou shalt receive.
Sweet! :)
2 patches attached. Both fix the original issue. One also adds the no sudo button.
Looks good in a (fairly brief) check. Thanks!
On Wed, 3 Dec 2025 at 22:29, Magnus Hagander <magnus@hagander.net> wrote:
On Wed, 3 Dec 2025 at 11:38, Dave Page <dpage@pgadmin.org> wrote:On Tue, 2 Dec 2025 at 14:41, Magnus Hagander <magnus@hagander.net> wrote:On Tue, 2 Dec 2025 at 12:30, Dave Page <dpage@pgadmin.org> wrote:The Copy Script buttons on the Linux package installation pages look horrific. See before.png.The attached patch makes them look much nicer, with proper sizing and an icon based button. On click, it briefly changes to a green checkmark to show confirmation. See the after screenshots.I'll apply this in a couple of days if there are no objections.LGTM in general and certainly is a lot prettier.Can you explain what that "fallback for text based buttons" is? Aren't they all replaced with icons?Oh, yeah. That's no longer needed now the patch is complete. I'll remove it.Oh, and I'm told you're not supposed to use "var" for variables in js due to the broken scoping :)Old habits die hard :-(And while you're poking at it, one thing I've really wanted is a "copy without the sudo parts". But I'm guessing that would be a lot more complicated than what you're fixing here...Ask and thou shalt receive.Sweet! :)2 patches attached. Both fix the original issue. One also adds the no sudo button.Looks good in a (fairly brief) check. Thanks!
Thanks - I fixed one more minor styling issue (minimum height of the code boxes), and applied the no-sudo version.
Dave Page
pgAdmin: https://www.pgadmin.org
PostgreSQL: https://www.postgresql.org
On 2025-Dec-04, Dave Page wrote: > Thanks - I fixed one more minor styling issue (minimum height of the code > boxes), and applied the no-sudo version. Hmm, when I click the no-sudo button, a green checkmark appears. But when I click the other one, the icon from the button disappears for a few seconds. I suppose that's not intended. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "People get annoyed when you try to debug them." (Larry Wall)
On Thu, 4 Dec 2025 at 15:18, Álvaro Herrera <alvherre@kurilemu.de> wrote:
On 2025-Dec-04, Dave Page wrote:
> Thanks - I fixed one more minor styling issue (minimum height of the code
> boxes), and applied the no-sudo version.
Hmm, when I click the no-sudo button, a green checkmark appears. But
when I click the other one, the icon from the button disappears for a
few seconds. I suppose that's not intended.
I can’t reproduce that on my laptop or phone. Do you need a hard refresh perhaps?
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"People get annoyed when you try to debug them." (Larry Wall)