Обсуждение: Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots

Поиск
Список
Период
Сортировка

Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots

От
Robert Haas
Дата:
On Fri, Nov 14, 2025 at 12:14 PM Andres Freund <andres@anarazel.de> wrote:
> I'm rather baffled by the process here. You pushed a patch, without any
> review, which also wasn't previously posted publicly, that made things
> worse. Then, after you got pushback on that change, you posted another patch,
> that got mildly negative feedback. Then you also pushed that change.

I'm not totally sure that we're in a worse place after these changes
than we were before them, but I strongly agree that committing a
change with no previous public discussion is a thing that generally
should not happen.

I mean, if the buildfarm is broken, pushing a fix quickly is
absolutely the right thing to do, but if you think the documentation
needs improving, there's no reason not to discuss that on
pgsql-hackers before pushing.

--
Robert Haas
EDB: http://www.enterprisedb.com



Re: pgsql: doc: remove verbiage about "receiving" data from rep. slots

От
Bruce Momjian
Дата:
On Wed, Nov 19, 2025 at 11:02:08AM -0500, Robert Haas wrote:
> On Fri, Nov 14, 2025 at 12:14 PM Andres Freund <andres@anarazel.de> wrote:
> > I'm rather baffled by the process here. You pushed a patch, without any
> > review, which also wasn't previously posted publicly, that made things
> > worse. Then, after you got pushback on that change, you posted another patch,
> > that got mildly negative feedback. Then you also pushed that change.
> 
> I'm not totally sure that we're in a worse place after these changes
> than we were before them, but I strongly agree that committing a
> change with no previous public discussion is a thing that generally
> should not happen.
> 
> I mean, if the buildfarm is broken, pushing a fix quickly is
> absolutely the right thing to do, but if you think the documentation
> needs improving, there's no reason not to discuss that on
> pgsql-hackers before pushing.

Yeah, I was trying to clean up what we had and I thought it was
no-controversial.  Obviously I was wrong.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Do not let urgent matters crowd out time for investment in the future.