Обсуждение: Add MERGE and VALUES statements to tab completion for PREPARE

On Mon, Nov 10, 2025 at 9:41 AM Haruna Miwa <miwa@sraoss.co.jp> wrote:
>
> Hi,
>
> As described in the manual[1], PREPARE ... AS command supports MERGE and VALUES statements, but current psql's tab
completiondoes not suggest them. 
> I created a patch that enables MERGE and VALUES to appear as tab completion suggestions.
>
> What do you think?

+1

Should we suggest "MERGE INTO" instead of just "MERGE",
since INTO always follows MERGE?

Also, how about adding "TABLE" and "WITH" to the suggestions,
similar to the tab-completion for "COPY ("?
SELECT statement can be specified in the PREPARE command,
and it can start with SELECT, TABLE, or WITH [1].

Regards,

[1] https://www.postgresql.org/docs/devel/sql-select.html

Regards,

--
Fujii Masao

On Thu, Nov 20, 2025 at 3:05 PM Haruna Miwa <miwa@sraoss.co.jp> wrote:
>
> > Should we suggest "MERGE INTO" instead of just "MERGE",
> > since INTO always follows MERGE?
> >
> > Also, how about adding "TABLE" and "WITH" to the suggestions,
> > similar to the tab-completion for "COPY ("?
> > SELECT statement can be specified in the PREPARE command,
> > and it can start with SELECT, TABLE, or WITH [1].
>
> Agreed.
> I have updated the patch.

Thanks for the update!

The patch looks good to me. I made one small adjustment: the updated line
was a bit long, so I added a line break. I also revised the commit message.

The updated patch is attached. I'll go ahead and commit it.

Regards,

--
Fujii Masao

On Fri, Nov 21, 2025 at 3:33 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Thu, Nov 20, 2025 at 3:05 PM Haruna Miwa <miwa@sraoss.co.jp> wrote:
> >
> > > Should we suggest "MERGE INTO" instead of just "MERGE",
> > > since INTO always follows MERGE?
> > >
> > > Also, how about adding "TABLE" and "WITH" to the suggestions,
> > > similar to the tab-completion for "COPY ("?
> > > SELECT statement can be specified in the PREPARE command,
> > > and it can start with SELECT, TABLE, or WITH [1].
> >
> > Agreed.
> > I have updated the patch.
>
> Thanks for the update!
>
> The patch looks good to me. I made one small adjustment: the updated line
> was a bit long, so I added a line break. I also revised the commit message.
>
> The updated patch is attached. I'll go ahead and commit it.

I've pushed the patch. Thanks!

Regards,

--
Fujii Masao