Обсуждение: pgsql: Fix POSIX compliance in pgwin32_unsetenv() for "name" argument

Поиск
Список
Период
Сортировка

pgsql: Fix POSIX compliance in pgwin32_unsetenv() for "name" argument

От
Michael Paquier
Дата:
Fix POSIX compliance in pgwin32_unsetenv() for "name" argument

pgwin32_unsetenv() (compatibility routine of unsetenv() on Windows)
lacks the input validation that its sibling pgwin32_setenv() has.
Without these checks, calling unsetenv() with incorrect names crashes on
WIN32.  However, invalid names should be handled, failing on EINVAL.

This commit adds the same checks as setenv() to fail with EINVAL for a
"name" set to NULL, an empty string, or if '=' is included in the value,
per POSIX requirements.

Like 7ca37fb0406b, backpatch down to v14.  pgwin32_unsetenv() is defined
on REL_13_STABLE, but with the branch going EOL soon and the lack of
setenv() there for WIN32, nothing is done for v13.

Author: Bryan Green <dbryan.green@gmail.com>
Discussion: https://postgr.es/m/b6a1e52b-d808-4df7-87f7-2ff48d15003e@gmail.com
Backpatch-through: 14

Branch
------
REL_18_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/52b05b068615ca13bc9aab6bd316c9a81c2e4d9a

Modified Files
--------------
src/port/win32env.c | 7 +++++++
1 file changed, 7 insertions(+)