Обсуждение: Fix incorrect function reference BufFileOpenShared in comment.

Поиск
Список
Период
Сортировка

Fix incorrect function reference BufFileOpenShared in comment.

От
Zhang Mingli
Дата:
Hi,

The comment incorrectly cited the defunct function BufFileOpenShared()
which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.

Update the reference to the current function: BufFileOpenFileSet().


--
Zhang Mingli
HashData
Вложения

Re: Fix incorrect function reference BufFileOpenShared in comment.

От
wenhui qiu
Дата:
Thank you for your path ，The path LGTM

On Wed, 1 Oct 2025 at 16:15, Zhang Mingli <zmlpostgres@gmail.com> wrote:
Hi,

The comment incorrectly cited the defunct function BufFileOpenShared()
which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.

Update the reference to the current function: BufFileOpenFileSet().


--
Zhang Mingli
HashData

Re: Fix incorrect function reference BufFileOpenShared in comment.

От
Richard Guo
Дата:
On Wed, Oct 1, 2025 at 5:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
> The comment incorrectly cited the defunct function BufFileOpenShared()
> which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.
>
> Update the reference to the current function: BufFileOpenFileSet().

Nice catch.  Running `git grep 'BufFile.*Shared'` confirms that this
is the only place referencing the outdated BufFileXXXShared()
functions.  I'll push this patch barring any objections.

- Richard

Re: Fix incorrect function reference BufFileOpenShared in comment.

От
Richard Guo
Дата:
On Wed, Oct 1, 2025 at 6:29 PM Richard Guo <guofenglinux@gmail.com> wrote:
> On Wed, Oct 1, 2025 at 5:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
> > The comment incorrectly cited the defunct function BufFileOpenShared()
> > which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.
> >
> > Update the reference to the current function: BufFileOpenFileSet().

> Nice catch.  Running `git grep 'BufFile.*Shared'` confirms that this
> is the only place referencing the outdated BufFileXXXShared()
> functions.  I'll push this patch barring any objections.

Pushed.

- Richard

Re: Fix incorrect function reference BufFileOpenShared in comment.

От
Mingli Zhang
Дата:
Thanks.

Richard Guo <guofenglinux@gmail.com>于2025年10月3日 周五15:41写道：
On Wed, Oct 1, 2025 at 6:29 PM Richard Guo <guofenglinux@gmail.com> wrote:
> On Wed, Oct 1, 2025 at 5:15 PM Zhang Mingli <zmlpostgres@gmail.com> wrote:
> > The comment incorrectly cited the defunct function BufFileOpenShared()
> > which is replaced in commit dcac5e7ac157964f71f15d81c7429130c69c3f9b.
> >
> > Update the reference to the current function: BufFileOpenFileSet().

> Nice catch.  Running `git grep 'BufFile.*Shared'` confirms that this
> is the only place referencing the outdated BufFileXXXShared()
> functions.  I'll push this patch barring any objections.

Pushed.

- Richard