Обсуждение: Fixed a minor typo in code comment

Поиск
Список
Период
Сортировка

Fixed a minor typo in code comment

От
Chao Li
Дата:
Hi,

I didn’t intend to modify the module, but noticed the typo while searching through the code. Submitting a patch to correct it.

I ran a basic test of “make check” and the test passed.


Chao Li (Evan)
--------------------
HighGo Infra. Software Inc.
https://www.highgo.com/


Вложения

Re: Fixed a minor typo in code comment

От
厉超
Дата:

Looks like the attachment was missing from the original email, adding the attachment.


-----原始邮件-----
发件人: "Chao Li" <lic@highgo.com>
发送时间: 2025-08-06 07:10:32 (星期三)
收件人: pgsql-hackers@postgresql.org
主题: Fixed a minor typo in code comment


Hi,

I didn’t intend to modify the module, but noticed the typo while searching through the code. Submitting a patch to correct it.

I ran a basic test of “make check” and the test passed.


Chao Li (Evan)
--------------------
HighGo Infra. Software Inc.
https://www.highgo.com/


Вложения

Re: Fixed a minor typo in code comment

От
Fujii Masao
Дата:
On Wed, Aug 6, 2025 at 8:11 AM Chao Li <lic@highgo.com> wrote:
>
> Hi,
>
> I didn’t intend to modify the module, but noticed the typo while searching through the code. Submitting a patch to
correctit. 
>
> I ran a basic test of “make check” and the test passed.

Thanks for the patch! LGTM.

The comment doesn't follow our usual style. How about adjusting it to
match our typical format while fixing the typo? I've attached
the updated version of the patch.

Regards,

--
Fujii Masao

Вложения

Re: Fixed a minor typo in code comment

От
Chao Li
Дата:
I am fine with that, and thanks for the v2 patch.

Chao Li (Evan)
--------------------
HighGo Infra. Software Inc.
https://www.highgo.com/



On Aug 6, 2025, at 12:11, Fujii Masao <masao.fujii@gmail.com> wrote:

On Wed, Aug 6, 2025 at 8:11 AM Chao Li <lic@highgo.com> wrote:

Hi,

I didn’t intend to modify the module, but noticed the typo while searching through the code. Submitting a patch to correct it.

I ran a basic test of “make check” and the test passed.

Thanks for the patch! LGTM.

The comment doesn't follow our usual style. How about adjusting it to
match our typical format while fixing the typo? I've attached
the updated version of the patch.

Regards,

--
Fujii Masao
<v2-0001-Fix-typo-in-comment.patch>

Re: Fixed a minor typo in code comment

От
Fujii Masao
Дата:
On Wed, Aug 6, 2025 at 1:17 PM Chao Li <lic@highgo.com> wrote:
>
> I am fine with that, and thanks for the v2 patch.

I've pushed the patch. Thanks!

Regards,

--
Fujii Masao