Обсуждение: pgsql: Remove misleading hint for "unexpected data beyond EOF" error.

Поиск
Список
Период
Сортировка

pgsql: Remove misleading hint for "unexpected data beyond EOF" error.

От
Robert Haas
Дата:
Remove misleading hint for "unexpected data beyond EOF" error.

Commit ffae5cc5a6024b4e25ec920ed5c4dfac649605f8 added this hint in 2006,
but it's now obsolete and doesn't reflect what users should really check
in this situation. We were not able to agree on a new hint, so just delete
the existing one and update the comments to mention one possibility that
is known to cause problems of this kind: something other than PostgreSQL
is modifying files in the PostgreSQL data directory.

Author: Jakub Wartak <jakub.wartak@enterprisedb.com>
Reviewed-by: Robert Haas <rhaas@postgresql.org>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Christoph Berg <myon@debian.org>
Discussion: https://postgr.es/m/CAKZiRmxNbcaL76x=09Sxf7aUmrRQJBf8drzDdUHo+j9_eM+VMg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d5b9b2d40262f57f58322ad49f8928fd4a492adb

Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)


Re: pgsql: Remove misleading hint for "unexpected data beyond EOF" error.

От
David Rowley
Дата:
On Tue, 29 Jul 2025 at 03:17, Robert Haas <rhaas@postgresql.org> wrote:
> Remove misleading hint for "unexpected data beyond EOF" error.

Just FYI, koel is failing the pgindent test from this:

-                * This has also been observed when relation was
overwritten by external
-                * process. Since the legitimate cases should always have left a
-                * zero-filled buffer, complain if not PageIsNew.
+                * This has also been observed when relation was overwritten by
+                * external process. Since the legitimate cases should
always have
+                * left a zero-filled buffer, complain if not PageIsNew.

David



Re: pgsql: Remove misleading hint for "unexpected data beyond EOF" error.

От
Robert Haas
Дата:
On Mon, Jul 28, 2025 at 11:30 PM David Rowley <dgrowleyml@gmail.com> wrote:
> On Tue, 29 Jul 2025 at 03:17, Robert Haas <rhaas@postgresql.org> wrote:
> > Remove misleading hint for "unexpected data beyond EOF" error.
>
> Just FYI, koel is failing the pgindent test from this:

Oops. Fixed, I hope.

--
Robert Haas
EDB: http://www.enterprisedb.com