Обсуждение: Remove unnecessary forward declaration for heapam_methods variable

Hi,

I think the forward declaration for heapam_methods variable in heapam_handler.c
is unnecessary, right?

-- 
Regrads,
Japin Li

From 77a6957e94692b3c4c9437c69cdbcb48ea53f3ee Mon Sep 17 00:00:00 2001
From: Japin Li <jianping.li@ww-it.cn>
Date: Wed, 31 Jul 2024 10:01:04 +0800
Subject: [PATCH v1 1/1] Remove unnecessary forward declaration for
 heapam_methods variable

---
 src/backend/access/heap/heapam_handler.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c
index 6f8b1b7929..e28047c201 100644
--- a/src/backend/access/heap/heapam_handler.c
+++ b/src/backend/access/heap/heapam_handler.c
@@ -56,8 +56,6 @@ static bool SampleHeapTupleVisible(TableScanDesc scan, Buffer buffer,
 
 static BlockNumber heapam_scan_get_blocks_done(HeapScanDesc hscan);
 
-static const TableAmRoutine heapam_methods;
-
 
 /* ------------------------------------------------------------------------
  * Slot related callbacks for heap AM
-- 
2.43.0

On Wed, Jul 31, 2024 at 10:36:11AM +0800, Japin Li wrote:
> I think the forward declaration for heapam_methods variable in heapam_handler.c
> is unnecessary, right?

True.  This can be removed because all the code paths using
heapam_methods are after its declaration, so duplicating it makes
little sense.  Thanks, applied.
--
Michael