Обсуждение: Fix grammar oddities in comments
Hi, See attached for a small patch fixing some typos and grammatical errors in a couple of comments. Side note: It's not clear to me what "Vars of higher levels don't matter here" means in this context (or how that claim is justified), but I haven't changed that part of the comment opting to simply resolve the clear mistakes in the wording here. Regards, James Coleman
Вложения
On Sun, 2 Jun 2024 at 10:08, James Coleman <jtc331@gmail.com> wrote: > See attached for a small patch fixing some typos and grammatical > errors in a couple of comments. Thanks. I pushed this after messing with the comments a bit more. > Side note: It's not clear to me what "Vars of higher levels don't > matter here" means in this context (or how that claim is justified), > but I haven't changed that part of the comment opting to simply > resolve the clear mistakes in the wording here. It just means Vars with varlevelsup >= 2 don't matter. It only cares about Vars with varlevelsup==1, i.e. Vars of the sub-query's direct parent. David
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation: not tested Confirming linguistic correctness of changes, and lack of anything changed outside of comments that would otherwise affectreadiness to commit. The new status of this patch is: Ready for Committer
On Wed, Jun 5, 2024 at 5:34 AM David Rowley <dgrowleyml@gmail.com> wrote: > > On Sun, 2 Jun 2024 at 10:08, James Coleman <jtc331@gmail.com> wrote: > > See attached for a small patch fixing some typos and grammatical > > errors in a couple of comments. > > Thanks. I pushed this after messing with the comments a bit more. Thanks! > > Side note: It's not clear to me what "Vars of higher levels don't > > matter here" means in this context (or how that claim is justified), > > but I haven't changed that part of the comment opting to simply > > resolve the clear mistakes in the wording here. > > It just means Vars with varlevelsup >= 2 don't matter. It only cares > about Vars with varlevelsup==1, i.e. Vars of the sub-query's direct > parent. Yes, I understood the content, but I didn't see any justification provided, which is what I'd hope for in a comment like this (why not simply what). Anyway, thanks again for reviewing and committing. James Coleman