Обсуждение: [Code Cleanup] : Small code cleanup in twophase.sql
Hi,
PFA small code cleanup in twophase.sql. Which contains a drop table
statement for 'test_prepared_savepoint'. Which, to me, appears to be
missing in the cleanup section of that file.
To support it I have below points:-
1) Grepping this table 'test_prepared_savepoint' shows occurrences
only in twophase.out & twophase.sql files. This means that table is
local to that sql test file and not used in any other test file.
2) I don't see any comment on why this was not added in the cleanup
section of twophase.sql, but drop for other two test tables are done.
3) I ran "make check-world" with the patch and I don't see any failures.
Kindly correct, if I missed anything.
Regards,
Nishant (EDB).
Вложения
Hi,
Any taker or rejector for above? -- It's a very small 'good to have' change patch for cleanup.
Thanks,
Nishant (EDB).
On Tue, Sep 26, 2023 at 6:31 PM Nishant Sharma <nishant.sharma@enterprisedb.com> wrote:
Hi,PFA small code cleanup in twophase.sql. Which contains a drop tablestatement for 'test_prepared_savepoint'. Which, to me, appears to bemissing in the cleanup section of that file.To support it I have below points:-1) Grepping this table 'test_prepared_savepoint' shows occurrencesonly in twophase.out & twophase.sql files. This means that table islocal to that sql test file and not used in any other test file.2) I don't see any comment on why this was not added in the cleanupsection of twophase.sql, but drop for other two test tables are done.3) I ran "make check-world" with the patch and I don't see any failures.Kindly correct, if I missed anything.Regards,Nishant (EDB).
On Tue, Sep 26, 2023 at 06:31:42PM +0530, Nishant Sharma wrote: > To support it I have below points:- > > 1) Grepping this table 'test_prepared_savepoint' shows occurrences > only in twophase.out & twophase.sql files. This means that table is > local to that sql test file and not used in any other test file. > > 2) I don't see any comment on why this was not added in the cleanup > section of twophase.sql, but drop for other two test tables are done. > > 3) I ran "make check-world" with the patch and I don't see any failures. Note that sometimes tables are left around in the regression tests for pg_upgrade, so as we can test dedicated upgrade paths for some object types. But, here, I think you're right: this is not a table that matters for an upgrade and the end of the test file also expects a cleanup. So okay for me to drop this table here. -- Michael