Обсуждение: [pgAdmin][GI-5308]: Cannot set a data field "default", makes it impossible to copy tuples with PK or SERIAL

Поиск
Список
Период
Сортировка

[pgAdmin][GI-5308]: Cannot set a data field "default", makes it impossible to copy tuples with PK or SERIAL

От
Nikhil Mohite
Дата:
Hi Hackers,

Please find attached the patch for GI-5308:  Cannot set a data field "default", makes it impossible to copy tuples with PK or SERIAL


--
Thanks & Regards,
Nikhil Mohite
Senior Software Engineer.
Mob.No: +91-7798364578.
Вложения

Re: [pgAdmin][GI-5308]: Cannot set a data field "default", makes it impossible to copy tuples with PK or SERIAL

От
Aditya Toshniwal
Дата:
Hi Nikhil,

I think this fix is incomplete. This is not particularly for PK. Non-PK columns can also have default values.
To cover all, the solution should be if a column which has default value is made empty then use default and not null.

On Wed, Sep 21, 2022 at 11:10 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

Please find attached the patch for GI-5308:  Cannot set a data field "default", makes it impossible to copy tuples with PK or SERIAL


--
Thanks & Regards,
Nikhil Mohite
Senior Software Engineer.
Mob.No: +91-7798364578.


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Hi Hackers,

PFA updated the patch.

On Wed, Sep 21, 2022 at 12:14 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Nikhil,

I think this fix is incomplete. This is not particularly for PK. Non-PK columns can also have default values.
To cover all, the solution should be if a column which has default value is made empty then use default and not null.

On Wed, Sep 21, 2022 at 11:10 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

Please find attached the patch for GI-5308:  Cannot set a data field "default", makes it impossible to copy tuples with PK or SERIAL


--
Thanks & Regards,
Nikhil Mohite
Senior Software Engineer.
Mob.No: +91-7798364578.


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

Regards,
Nikhil Mohite 
Вложения

Re: [pgAdmin][GI-5308]: Cannot set a data field "default", makes it impossible to copy tuples with PK or SERIAL

От
Aditya Toshniwal
Дата:
Hi,

The patch looks good to me.

On Wed, Sep 21, 2022 at 12:35 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

PFA updated the patch.

On Wed, Sep 21, 2022 at 12:14 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Nikhil,

I think this fix is incomplete. This is not particularly for PK. Non-PK columns can also have default values.
To cover all, the solution should be if a column which has default value is made empty then use default and not null.

On Wed, Sep 21, 2022 at 11:10 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

Please find attached the patch for GI-5308:  Cannot set a data field "default", makes it impossible to copy tuples with PK or SERIAL


--
Thanks & Regards,
Nikhil Mohite
Senior Software Engineer.
Mob.No: +91-7798364578.


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

Regards,
Nikhil Mohite 


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"
Thanks, the patch was applied.

On Wed, Sep 21, 2022 at 1:57 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

The patch looks good to me.

On Wed, Sep 21, 2022 at 12:35 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

PFA updated the patch.

On Wed, Sep 21, 2022 at 12:14 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Nikhil,

I think this fix is incomplete. This is not particularly for PK. Non-PK columns can also have default values.
To cover all, the solution should be if a column which has default value is made empty then use default and not null.

On Wed, Sep 21, 2022 at 11:10 AM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Hackers,

Please find attached the patch for GI-5308:  Cannot set a data field "default", makes it impossible to copy tuples with PK or SERIAL


--
Thanks & Regards,
Nikhil Mohite
Senior Software Engineer.
Mob.No: +91-7798364578.


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

Regards,
Nikhil Mohite 


--
Thanks,
Aditya Toshniwal
pgAdmin Hacker | Software Architect | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--

Akshay Joshi

Principal Software Architect

+91 9767888246

www.enterprisedb.com