Обсуждение: Revive targetServerType=preferPrimary feature

Поиск
Список
Период
Сортировка

Revive targetServerType=preferPrimary feature

От
"Mukhin, Dmitriy"
Дата:

Hi All,

 

In 2019, there was a discussion on implementing the targetServerType=preferPrimary JDBC driver parameter feature (see here: How to send queries to master and failover to slave ?) and a Pull Request created for that ( https://github.com/pgjdbc/pgjdbc/pull/1430 ). The project I’m working on would greatly benefit from merging this PR and apparently there were other people that requested this feature before. Can we revive this PR and reconsider its merging? Alternatively, I can create a fresh PR with the same changes against current master branch and submit it for review. Please let me know what I can do to make this change happen.

 

Thank you!

 

Dmitriy Mukhin

Re: Revive targetServerType=preferPrimary feature

От
"Mukhin, Dmitriy"
Дата:
I have created https://github.com/pgjdbc/pgjdbc/pull/2483 per our conversation below. Can you please review it and let
meknow if anything else needs to be done?
 

Thanks,

Dmitriy


From: Dave Cramer <pg@fastcrypt.com>
Date: Thursday, March 24, 2022 at 10:42 AM
To: "Mukhin, Dmitriy" <dmukhin@verisign.com>
Cc: "pgsql-jdbc@postgresql.org" <pgsql-jdbc@postgresql.org>
Subject: Re: Revive targetServerType=preferPrimary feature

> On Thu, 24 Mar 2022 at 10:35, Mukhin, Dmitriy <dmukhin(at)verisign(dot)com> wrote:
>
> > Hi All,
> >
> > In 2019, there was a discussion on implementing the
> > targetServerType=preferPrimary JDBC driver parameter feature (see here: How
> > to send queries to master and failover to slave ?
> >
<https://www.postgresql.org/message-id/VI1PR05MB5295BA974B84191217A6A613BC760%40VI1PR05MB5295.eurprd05.prod.outlook.com>)
> > and a Pull Request created for that (
> > https://github.com/pgjdbc/pgjdbc/pull/1430 ). The project I’m working on
> > would greatly benefit from merging this PR and apparently there were other
> > people that requested this feature before. Can we revive this PR and
> > reconsider its merging? Alternatively, I can create a fresh PR with the
> > same changes against current master branch and submit it for review. Please
> > let me know what I can do to make this change happen.
> >
> > Thank you!
> >
> > Dmitriy Mukhin
> >
>
> It needs to be cleaned up so yes, please create a new PR.
>
> Thanks,
>
> Dave
>