pgsql: Close yet another race condition in replication slot test code

Поиск
Список
Период
Сортировка
Искать

pgsql: Close yet another race condition in replication slot test code

От:
Alvaro Herrera <alvherre@alvh.no-ip.org>
Дата:
Close yet another race condition in replication slot test code

Buildfarm shows that this test has a further failure mode when a
checkpoint starts earlier than expected, so we detect a "checkpoint
completed" line that's not the one we want.  Change the config to try
and prevent this.

Per buildfarm

While at it, update one comment that was forgotten in commit
d18e75664a2f.

Author: Kyotaro Horiguchi 
Discussion: https://postgr.es/m/20210729.162038.534808353849568395.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ce197e91d02ca38ac1b956a3e0c11596099e7893

Modified Files
--------------
src/backend/access/transam/xlog.c         |  2 +-
src/test/recovery/t/019_replslot_limit.pl | 14 ++++++++++++--
2 files changed, 13 insertions(+), 3 deletions(-)

Re: pgsql: Close yet another race condition in replication slot test code

От:
Tom Lane <tgl@sss.pgh.pa.us>
Дата:
Alvaro Herrera  writes:
> Close yet another race condition in replication slot test code

Shouldn't that have gone into v13, too?

			regards, tom lane


Re: pgsql: Close yet another race condition in replication slot test code

От:
Alvaro Herrera <alvherre@alvh.no-ip.org>
Дата:
On 2021-Jul-29, Tom Lane wrote:

> Alvaro Herrera  writes:
> > Close yet another race condition in replication slot test code
> 
> Shouldn't that have gone into v13, too?

Oh, oops, yeah, I confused how recent this feature is.  Will do in a
minute.

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/
"Always assume the user will do much worse than the stupidest thing
you can imagine."                                (Julien PUYDT)


FAQ