Improve SQLSTATE reporting in some replication-related code.
I started out with the goal of reporting ERRCODE_CONNECTION_FAILURE
when walrcv_connect() fails, but as I looked around I realized that
whoever wrote this code was of the opinion that errcodes are purely
optional. That's not my understanding of our project policy. Hence,
make sure that an errcode is provided in each ereport that (a) is
ERROR or higher level and (b) isn't arguably an internal logic error.
Also fix some very dubious existing errcode assignments.
While this is not per policy, it's also largely cosmetic, since few
of these cases could get reported to applications. So I don't
feel a need to back-patch.
Discussion: https://postgr.es/m/2189704.1623512522@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6b787d9e32005867ee3660d1ea20f447810a403d
Modified Files
--------------
src/backend/commands/subscriptioncmds.c | 29 ++++++-----
.../libpqwalreceiver/libpqwalreceiver.c | 60 ++++++++++++++--------
src/backend/replication/logical/tablesync.c | 21 +++++---
src/backend/replication/logical/worker.c | 6 ++-
src/backend/replication/walreceiver.c | 19 ++++---
5 files changed, 88 insertions(+), 47 deletions(-)