Обсуждение: pgsql: Improve log pattern detection in recently-added TAP tests

Поиск
Список
Период
Сортировка

pgsql: Improve log pattern detection in recently-added TAP tests

От
Michael Paquier
Дата:
Improve log pattern detection in recently-added TAP tests

ab55d74 has introduced some tests with rows found as missing in logical
replication subscriptions for partitioned tables, relying on a logic
with a lookup of the logs generated, scanning the whole file.  This
commit makes the logic more precise, by scanning the logs only from the
position before the key queries are run to the position where we check
for the logs.  This will reduce the risk of issues with log patterns
overlapping with each other if those tests get more complicated in the
future.

Per discussion with Tom Lane.

Discussion: https://postgr.es/m/YMP+Gx2S8meYYHW4@paquier.xyz
Backpatch-through: 13

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/fad9c8e93a65f087033312cd655511a28d07ab51

Modified Files
--------------
src/test/subscription/t/001_rep_changes.pl |  7 ++++++-
src/test/subscription/t/013_partition.pl   | 14 ++++++++++++--
2 files changed, 18 insertions(+), 3 deletions(-)