Обсуждение: [pgAdmin][RM4855] Renaming a file removes the file extension

Hi Hackers,

Attached is the patch to fix a bug where extension file extension is stripped on renaming a file.

Pleasure review.

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

Thanks, patch applied.

On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch to fix a bug where extension file extension is stripped on renaming a file.

Pleasure review.

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Sr. Software Architect

EDB Postgres

Mobile: +91 976-788-8246

Hi,

Attached patch will add the .sql when saving a file and and format -> sql selected, no matter what the file name is.

Please review.

On Thu, Oct 8, 2020 at 6:27 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch to fix a bug where extension file extension is stripped on renaming a file.

Pleasure review.

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Sr. Software Architect

EDB Postgres

Mobile: +91 976-788-8246

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

Thanks, patch applied.

On Thu, Oct 8, 2020 at 6:34 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

Attached patch will add the .sql when saving a file and and format -> sql selected, no matter what the file name is.

Please review.

On Thu, Oct 8, 2020 at 6:27 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch to fix a bug where extension file extension is stripped on renaming a file.

Pleasure review.

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Sr. Software Architect

EDB Postgres

Mobile: +91 976-788-8246

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Sr. Software Architect

EDB Postgres

Mobile: +91 976-788-8246

Hi Hackers,

Attached is a patch to improve this further. It will skip adding the extension if the file already has the extension selected from the format dropdown.

Please review.

On Fri, Oct 9, 2020 at 11:53 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Thu, Oct 8, 2020 at 6:34 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

Attached patch will add the .sql when saving a file and and format -> sql selected, no matter what the file name is.

Please review.

On Thu, Oct 8, 2020 at 6:27 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Mon, Sep 28, 2020 at 6:08 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi Hackers,

Attached is the patch to fix a bug where extension file extension is stripped on renaming a file.

Pleasure review.

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Sr. Software Architect

EDB Postgres

Mobile: +91 976-788-8246

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Sr. Software Architect

EDB Postgres

Mobile: +91 976-788-8246

--

Thanks,

Aditya Toshniwal

pgAdmin hacker | Sr. Software Engineer | edbpostgres.com

"Don't Complain about Heat, Plant a TREE"