Обсуждение: [PATCH] reset-db test: use the common definition of env/conn

Поиск
Список
Период
Сортировка

[PATCH] reset-db test: use the common definition of env/conn

От
Paul Wise
Дата:
Test builds fail with GCC 10 due to conflicting variable names:

/usr/bin/ld: exe/common.o:(.bss+0x8): multiple definition of `env'; /tmp/ccqfSqFX.o:(.bss+0x8): first defined here
/usr/bin/ld: exe/common.o:(.bss+0x0): multiple definition of `conn'; /tmp/ccqfSqFX.o:(.bss+0x0): first defined here

Fixes: https://bugs.debian.org/957714
---
 test/reset-db.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/test/reset-db.c b/test/reset-db.c
index 80946c8..5e05019 100644
--- a/test/reset-db.c
+++ b/test/reset-db.c
@@ -17,8 +17,6 @@
 
 #include "src/common.h"
 
-SQLHENV env;
-SQLHDBC conn;
 static HSTMT hstmt = SQL_NULL_HSTMT;
 
 static void
-- 
2.27.0




Re: [PATCH] reset-db test: use the common definition of env/conn

От
"Inoue, Hiroshi"
Дата:
Hi Paul,

I would commit the patch.

Thanks.
Hiroshi Inoue

On 2020/07/26 14:16, Paul Wise wrote:
> Test builds fail with GCC 10 due to conflicting variable names:
>
> /usr/bin/ld: exe/common.o:(.bss+0x8): multiple definition of `env'; /tmp/ccqfSqFX.o:(.bss+0x8): first defined here
> /usr/bin/ld: exe/common.o:(.bss+0x0): multiple definition of `conn'; /tmp/ccqfSqFX.o:(.bss+0x0): first defined here
>
> Fixes: https://bugs.debian.org/957714
> ---
>   test/reset-db.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/test/reset-db.c b/test/reset-db.c
> index 80946c8..5e05019 100644
> --- a/test/reset-db.c
> +++ b/test/reset-db.c
> @@ -17,8 +17,6 @@
>   
>   #include "src/common.h"
>   
> -SQLHENV env;
> -SQLHDBC conn;
>   static HSTMT hstmt = SQL_NULL_HSTMT;
>   
>   static void