Fix YA text phrase search bug.
checkcondition_str() failed to report multiple matches for a prefix
pattern correctly: it would dutifully merge the match positions, but
then after exiting that loop, if the last prefix-matching word had
had no suitable positions, it would report there were no matches.
The upshot would be failing to recognize a match that the query
should match.
It looks like you need all of these conditions to see the bug:
* a phrase search (else we don't ask for match position details)
* a prefix search item (else we don't get to this code)
* a weight restriction (else checkclass_str won't fail)
Noted while investigating a problem report from Pavel Borisov,
though this is distinct from the issue he was on about.
Back-patch to 9.6 where phrase search was added.
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/7c9d9aa5ca2dd9b7661b2a2de75a3b963f3bc17c
Modified Files
--------------
src/backend/utils/adt/tsvector_op.c | 8 +++++++-
src/test/regress/expected/tstypes.out | 18 ++++++++++++++++++
src/test/regress/sql/tstypes.sql | 3 +++
3 files changed, 28 insertions(+), 1 deletion(-)