Обсуждение: [pgAdmin][RM5410] Package Body is not being removed
Hi Hackers
--
RM #5410 has been reopened. Problem Statement: When we change the definition of the package header it will delete the existing package body. I confirmed that this is the expected behavior in the EDB Postgres Advanced Server.
Attached is the patch to just popped up the warning message for the user before saving it.
Note: Warning message will be displayed only when the package header is changed if we change the package body then no need to popped up the warning message.
Please review it.
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Вложения
I will be reviewing this patch.
On Thu, Apr 23, 2020 at 3:30 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi HackersRM #5410 has been reopened. Problem Statement: When we change the definition of the package header it will delete the existing package body. I confirmed that this is the expected behavior in the EDB Postgres Advanced Server.Attached is the patch to just popped up the warning message for the user before saving it.Note: Warning message will be displayed only when the package header is changed if we change the package body then no need to popped up the warning message.Please review it.--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246
Thanks & Regards,
Shubham Agarwal
Shubham Agarwal
EnterpriseDB Corporation
The Postgres Database Company
Patch looks good to me.
Please go ahead and commit the code.
On Thu, Apr 23, 2020 at 4:25 PM Shubham Agarwal <shubham.agarwal@enterprisedb.com> wrote:
I will be reviewing this patch.On Thu, Apr 23, 2020 at 3:30 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:Hi HackersRM #5410 has been reopened. Problem Statement: When we change the definition of the package header it will delete the existing package body. I confirmed that this is the expected behavior in the EDB Postgres Advanced Server.Attached is the patch to just popped up the warning message for the user before saving it.Note: Warning message will be displayed only when the package header is changed if we change the package body then no need to popped up the warning message.Please review it.--Thanks & RegardsAkshay JoshiSr. Software ArchitectEnterpriseDB Software India Private LimitedMobile: +91 976-788-8246--Thanks & Regards,
Shubham AgarwalEnterpriseDB CorporationThe Postgres Database Company
Thanks & Regards,
Shubham Agarwal
Shubham Agarwal
EnterpriseDB Corporation
The Postgres Database Company