Обсуждение: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.

Поиск
Список
Период
Сортировка

[pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does not show OID.

От
Khushboo Vashi
Дата:
Hi,

Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.

As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.

Thanks,
Khushboo

Вложения

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.

От
Akshay Joshi
Дата:
Hi Khushboo

Schema Diff test cases are failing with this patch. Please fix and resend the patch.

On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.

As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.

Thanks,
Khushboo



--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.

От
Ashesh Vashi
Дата:
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.

As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.
Question is: When we rename a synonym, does it create a new OID, or keep the same?

-- Ashesh

Thanks,
Khushboo

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.

От
Khushboo Vashi
Дата:


On Wed, Apr 8, 2020 at 12:40 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.

As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.
Question is: When we rename a synonym, does it create a new OID, or keep the same?

We can not rename a synonym, must drop it and recreate it. 
 
-- Ashesh

Thanks,
Khushboo

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.

От
Akshay Joshi
Дата:
Hi Khushboo

View/MView test also failing with the commit of #5053. Please fix those as well and send a combined patch.

On Wed, Apr 8, 2020 at 12:47 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Wed, Apr 8, 2020 at 12:40 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.

As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.
Question is: When we rename a synonym, does it create a new OID, or keep the same?

We can not rename a synonym, must drop it and recreate it. 
 
-- Ashesh

Thanks,
Khushboo



--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.

От
Khushboo Vashi
Дата:
Hi Akshay,

On Wed, Apr 8, 2020 at 12:33 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo

Schema Diff test cases are failing with this patch. Please fix and resend the patch.

Can you please re-verify as I don't think schema diff test cases are failing due to this patch.

Thanks,
Khushboo 
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.

As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.

Thanks,
Khushboo



--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.

От
Khushboo Vashi
Дата:
Hi,

Please find the attached updated patch.

Thanks,
Khushboo

On Fri, Apr 10, 2020 at 10:41 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Akshay,

On Wed, Apr 8, 2020 at 12:33 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo

Schema Diff test cases are failing with this patch. Please fix and resend the patch.

Fixed.

Thanks,
Khushboo 
Can you please re-verify as I don't think schema diff test cases are failing due to this patch.

Thanks,
Khushboo 
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.

As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.

Thanks,
Khushboo



--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Вложения

Re: [pgAdmin4][Patch] - RM 5270 - [EPAS] Synonym properties does notshow OID.

От
Akshay Joshi
Дата:
Thanks patch applied.

On Fri, Apr 10, 2020 at 11:58 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached updated patch.

Thanks,
Khushboo

On Fri, Apr 10, 2020 at 10:41 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Akshay,

On Wed, Apr 8, 2020 at 12:33 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Khushboo

Schema Diff test cases are failing with this patch. Please fix and resend the patch.

Fixed.

Thanks,
Khushboo 
Can you please re-verify as I don't think schema diff test cases are failing due to this patch.

Thanks,
Khushboo 
On Tue, Apr 7, 2020 at 6:37 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

Please find the attached patch to fix the RM # 5270 - [EPAS] Synonym properties does not show OID.

As per the current implementation, we completely ignored OID and instead considered the name as the unique field, now with this patch OID will be used as an unique id and also will display OID in the properties tab.

Thanks,
Khushboo



--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246