Обсуждение: PgAgent leap year problem
Hi,
Scheduled tasks set as the last day of February this year did not work. In your schedule function have a small bug. Leap year function get year parameter, but your code is sending day as a parameter. Fixing patch attached in this mail.
Best Regards...
--
MEHMET EMİN KARAKAŞ
PostgreSQL DBA
Turksat Satellite Communication and Cable TV Operations
Konya Yolu 40. Km. 06839 Golbasi / ANKARA - TÜRKİYE
Tel : +90 312 615 32 73
Faks : +90 312 615 32 77
PostgreSQL DBA
Turksat Satellite Communication and Cable TV Operations
Konya Yolu 40. Km. 06839 Golbasi / ANKARA - TÜRKİYE
Tel : +90 312 615 32 73
Faks : +90 312 615 32 77
Вложения
Hi Mehmet,
It was a bug in pgAgent. Thank you for sharing the patch. I have reviewed and tested, it is working fine.
Dave/Ashesh:- Can we commit this patch ?
Thanks,
Neel Patel
On Mon, Mar 2, 2020 at 5:26 PM Mehmet Emin KARAKAŞ <emin100@gmail.com> wrote:
Hi,Scheduled tasks set as the last day of February this year did not work. In your schedule function have a small bug. Leap year function get year parameter, but your code is sending day as a parameter. Fixing patch attached in this mail.Best Regards...--MEHMET EMİN KARAKAŞ
PostgreSQL DBA
Turksat Satellite Communication and Cable TV Operations
Konya Yolu 40. Km. 06839 Golbasi / ANKARA - TÜRKİYE
Tel : +90 312 615 32 73
Faks : +90 312 615 32 77
On Wed, Mar 4, 2020 at 10:53 AM Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Mehmet,It was a bug in pgAgent. Thank you for sharing the patch. I have reviewed and tested, it is working fine.Dave/Ashesh:- Can we commit this patch ?
Mehmet,
Thanks for your patch.
Changes look good except it does not take care of the upgrade scenarios.
Hence - updated the patch for the same.
Neel,
Would you please review the updated patch with the upgrade scenarios?
-- Thanks, Ashesh
Thanks,Neel PatelOn Mon, Mar 2, 2020 at 5:26 PM Mehmet Emin KARAKAŞ <emin100@gmail.com> wrote:Hi,Scheduled tasks set as the last day of February this year did not work. In your schedule function have a small bug. Leap year function get year parameter, but your code is sending day as a parameter. Fixing patch attached in this mail.Best Regards...--MEHMET EMİN KARAKAŞ
PostgreSQL DBA
Turksat Satellite Communication and Cable TV Operations
Konya Yolu 40. Km. 06839 Golbasi / ANKARA - TÜRKİYE
Tel : +90 312 615 32 73
Faks : +90 312 615 32 77
Вложения
Hi Ashesh,
I have reviewed it and looks good. I have updated the sql version in header of each sql file.
Thanks,
Neel Patel
On Wed, Mar 4, 2020 at 12:22 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Wed, Mar 4, 2020 at 10:53 AM Neel Patel <neel.patel@enterprisedb.com> wrote:Hi Mehmet,It was a bug in pgAgent. Thank you for sharing the patch. I have reviewed and tested, it is working fine.Dave/Ashesh:- Can we commit this patch ?Mehmet,Thanks for your patch.Changes look good except it does not take care of the upgrade scenarios.Hence - updated the patch for the same.Neel,Would you please review the updated patch with the upgrade scenarios?-- Thanks, AsheshThanks,Neel PatelOn Mon, Mar 2, 2020 at 5:26 PM Mehmet Emin KARAKAŞ <emin100@gmail.com> wrote:Hi,Scheduled tasks set as the last day of February this year did not work. In your schedule function have a small bug. Leap year function get year parameter, but your code is sending day as a parameter. Fixing patch attached in this mail.Best Regards...--MEHMET EMİN KARAKAŞ
PostgreSQL DBA
Turksat Satellite Communication and Cable TV Operations
Konya Yolu 40. Km. 06839 Golbasi / ANKARA - TÜRKİYE
Tel : +90 312 615 32 73
Faks : +90 312 615 32 77
Вложения
On Wed, Mar 4, 2020 at 12:36 PM Neel Patel <neel.patel@enterprisedb.com> wrote:
Hi Ashesh,I have reviewed it and looks good. I have updated the sql version in header of each sql file.
Thanks Neel.
Committed the patch with the change suggested offline regarding the updated version in the windows resource (.rc) files.
-- Thanks, Ashesh
Thanks,Neel PatelOn Wed, Mar 4, 2020 at 12:22 PM Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:On Wed, Mar 4, 2020 at 10:53 AM Neel Patel <neel.patel@enterprisedb.com> wrote:Hi Mehmet,It was a bug in pgAgent. Thank you for sharing the patch. I have reviewed and tested, it is working fine.Dave/Ashesh:- Can we commit this patch ?Mehmet,Thanks for your patch.Changes look good except it does not take care of the upgrade scenarios.Hence - updated the patch for the same.Neel,Would you please review the updated patch with the upgrade scenarios?-- Thanks, AsheshThanks,Neel PatelOn Mon, Mar 2, 2020 at 5:26 PM Mehmet Emin KARAKAŞ <emin100@gmail.com> wrote:Hi,Scheduled tasks set as the last day of February this year did not work. In your schedule function have a small bug. Leap year function get year parameter, but your code is sending day as a parameter. Fixing patch attached in this mail.Best Regards...--MEHMET EMİN KARAKAŞ
PostgreSQL DBA
Turksat Satellite Communication and Cable TV Operations
Konya Yolu 40. Km. 06839 Golbasi / ANKARA - TÜRKİYE
Tel : +90 312 615 32 73
Faks : +90 312 615 32 77