Обсуждение: [PATCH] Tab completion for CREATE OR REPLACE

Hello, hackers:

I created a patch about tab completion for command CREATE OR REPLACE in psql
includes:
    CREATE [ OR REPLACE ] FUNCTION
    CREATE [ OR REPLACE ] PROCEDURE
    CREATE [ OR REPLACE ] LANGUAGE
    CREATE [ OR REPLACE ] RULE name AS ON event
    CREATE [ OR REPLACE ] VIEW AS SELECT
    CREATE [ OR REPLACE ] AGGREGATE
    CREATE [ OR REPLACE ] TRANSFORM

------------------------------------------------------------------------------------------
Regards
Shenhao Wang

On Thu, 22 Aug 2019 at 15:05, Wang, Shenhao <wangsh.fnst@cn.fujitsu.com> wrote:
>
> Hello, hackers:
>
> I created a patch about tab completion for command CREATE OR REPLACE in psql
> includes:
>         CREATE [ OR REPLACE ] FUNCTION
>         CREATE [ OR REPLACE ] PROCEDURE
>         CREATE [ OR REPLACE ] LANGUAGE
>         CREATE [ OR REPLACE ] RULE name AS ON event
>         CREATE [ OR REPLACE ] VIEW AS SELECT
>         CREATE [ OR REPLACE ] AGGREGATE
>         CREATE [ OR REPLACE ] TRANSFORM
>
> ------------------------------------------------------------------------------------------

Could you add this to the next commitfest?

    https://commitfest.postgresql.org/24/

Regards

Ian Barwick

--
  Ian Barwick                   https://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services

On Thu, Aug 22, 2019 at 3:06 PM Wang, Shenhao
<wangsh.fnst@cn.fujitsu.com> wrote:
>
> Hello, hackers:
>
> I created a patch about tab completion for command CREATE OR REPLACE in psql
> includes:
>         CREATE [ OR REPLACE ] FUNCTION
>         CREATE [ OR REPLACE ] PROCEDURE
>         CREATE [ OR REPLACE ] LANGUAGE
>         CREATE [ OR REPLACE ] RULE name AS ON event
>         CREATE [ OR REPLACE ] VIEW AS SELECT
>         CREATE [ OR REPLACE ] AGGREGATE
>         CREATE [ OR REPLACE ] TRANSFORM

Thanks for the patch! The patch looks good to me.
Barring no objection, I will commit this.

Regards,

-- 
Fujii Masao

On Tue, Sep 3, 2019 at 11:04 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Thu, Aug 22, 2019 at 3:06 PM Wang, Shenhao
> <wangsh.fnst@cn.fujitsu.com> wrote:
> >
> > Hello, hackers:
> >
> > I created a patch about tab completion for command CREATE OR REPLACE in psql
> > includes:
> >         CREATE [ OR REPLACE ] FUNCTION
> >         CREATE [ OR REPLACE ] PROCEDURE
> >         CREATE [ OR REPLACE ] LANGUAGE
> >         CREATE [ OR REPLACE ] RULE name AS ON event
> >         CREATE [ OR REPLACE ] VIEW AS SELECT
> >         CREATE [ OR REPLACE ] AGGREGATE
> >         CREATE [ OR REPLACE ] TRANSFORM
>
> Thanks for the patch! The patch looks good to me.

Committed. Thanks!

Regards,

-- 
Fujii Masao