Обсуждение: pgAdmin4 v4.11 candidate builds

Hi All,

pgAdmin4 v4.11 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-07-23-1/

Fahar, can you please verify it for release on Thursday.

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

Hi Akshay,

On Tue, 2019-07-23 at 11:01 +0530, Akshay Joshi wrote:
> pgAdmin4 v4.11 candidate builds and source can be found at
> https://developer.pgadmin.org/builds/2019-07-23-1/

Where can I get some info about html_theme parameter change? I used to change
it from classic to default in the RPMs, and now it is pgadmin4 by default. The
PDF doc does not include any info about this.

Cheers,
--
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

On Tue, 2019-07-23 at 11:01 +0530, Akshay Joshi wrote:
> Hi All,
>
> pgAdmin4 v4.11 candidate builds and source can be found at
> https://developer.pgadmin.org/builds/2019-07-23-1/

Just hit an issue on RHEL 7 (Python 2.7.5) :

+ /usr/lib/rpm/brp-python-bytecompile /usr/bin/python 1
Bytecompiling .py files below /var/lib/pgsql/rpm11testing/BUILDROOT/pgadmin4-4.11-1.rhel7.x86_64/usr/lib/python2.7 using /usr/bin/python2.7
Compiling /var/lib/pgsql/rpm11testing/BUILDROOT/pgadmin4-4.11-1.rhel7.x86_64/usr/lib/python2.7/site-packages/pgadmin4-web/pgadmin/feature_tests/query_tool_journey_test.py ...
  File "/usr/lib/python2.7/site-packages/pgadmin4-web/pgadmin/feature_tests/query_tool_journey_test.py", line 57
    print("Copy rows...", file=sys.stderr, end="")
                              ^
SyntaxError: invalid syntax


Any ideas?

Regards,
--
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

Hi,

On Wed, 2019-07-24 at 10:48 +0530, Akshay Joshi wrote:
>    Feature test are not stable yet, so we will have to remove that from our
> build process.

How? Will you re-wrap 4.11? If not, can you please send me a patch so that I
can apply it to the RPMs?

Thanks!

Cheers,
--
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

Hi Devrim

On Wed, Jul 24, 2019 at 1:02 PM Devrim Gündüz <devrim@gunduz.org> wrote:

Hi,

On Wed, 2019-07-24 at 10:48 +0530, Akshay Joshi wrote:
>    Feature test are not stable yet, so we will have to remove that from our
> build process.

How? Will you re-wrap 4.11? If not, can you please send me a patch so that I
can apply it to the RPMs?

   No, I'll not re-wrap 4.11. I am not much aware of the RPM's, but I think you will need to change the spec file and add "--exclude feature_tests" parameter to the command for regression test.   

Hi Ashesh,

On Tue, 2019-07-23 at 21:58 +0530, Ashesh Vashi wrote:
> Because - pgAdmin4 has its own documentation theme. :-)

Thanks, but this does not answer my question. This theme (like the previous
"classic" theme) breaks RHEL 7 builds:

Running Sphinx v1.1.3
loading pickled environment... not yet created

Theme error:
no theme named 'classic' found, inherited by 'pgadmin4'
make[2]: *** [html] Error 1
make[2]: Leaving directory `/home/pgsql/git/pgrpms/rpm/redhat/master/pgadmin4/master/pgadmin4-4.11/docs/en_US'
make[1]: *** [docs] Error 2
make[1]: Leaving directory `/home/pgsql/git/pgrpms/rpm/redhat/master/pgadmin4/master/pgadmin4-4.11'
error: Bad exit status from /var/tmp/rpm-tmp.Afb3Zm (%build)

So, I updated the patch, and used the default theme again in 4.11 RPMs.

On Wed, 24 Jul, 2019, 19:26 Devrim Gündüz, <devrim@gunduz.org> wrote:

Hi Akshay,

On Wed, 2019-07-24 at 14:45 +0530, Akshay Joshi wrote:
> We have figure out the problem with the syntax print("Copy rows...",
> file=sys.stderr, end="") with Python 2.7.
> Attached is the patch please apply, test it and let me know.

Great, it worked!

Will this patch be included in 4.12?

    @Dave, Can you please comment on this. If we include this patch in 4.11, I'll have to rewrap the candidate build.