Обсуждение: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)

Поиск
Список
Период
Сортировка

[pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)

От
Aditya Toshniwal
Дата:
Hi Hackers,

My pull request(https://github.com/EnterpriseDB/wcDocker/pull/5) to fix resize issue in wcDocker is merged. Attached patch will update the version of wcDocker and fix the issue in pgAdmin4.
Do not forget to yarn install.

Kindly review.


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Вложения

Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)

От
Dave Page
Дата:
Thanks, applied.

Do we still need our fork of wcDocker?

Also, please let me know when you're running low on things to do in this sprint (not including schema diff). I have one other issue I'd like to get worked on ASAP.

Thanks!

On Thu, Mar 21, 2019 at 5:28 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

My pull request(https://github.com/EnterpriseDB/wcDocker/pull/5) to fix resize issue in wcDocker is merged. Attached patch will update the version of wcDocker and fix the issue in pgAdmin4.
Do not forget to yarn install.

Kindly review.


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)

От
Aditya Toshniwal
Дата:
Hi,

On Thu, Mar 21, 2019 at 2:51 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

Do we still need our fork of wcDocker?
Yes we do. pgAdmin depends on changes done on forked wcDocker. 

Also, please let me know when you're running low on things to do in this sprint (not including schema diff). I have one other issue I'd like to get worked on ASAP.
Yeah, please let me know. I am available. 

Thanks!

On Thu, Mar 21, 2019 at 5:28 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

My pull request(https://github.com/EnterpriseDB/wcDocker/pull/5) to fix resize issue in wcDocker is merged. Attached patch will update the version of wcDocker and fix the issue in pgAdmin4.
Do not forget to yarn install.

Kindly review.


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)

От
Dave Page
Дата:


On Thu, Mar 21, 2019 at 9:24 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

On Thu, Mar 21, 2019 at 2:51 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

Do we still need our fork of wcDocker?
Yes we do. pgAdmin depends on changes done on forked wcDocker. 

Also, please let me know when you're running low on things to do in this sprint (not including schema diff). I have one other issue I'd like to get worked on ASAP.
Yeah, please let me know. I am available. 


I'd like to discuss first though - are you available in the next 5 or 10 minutes
 

Thanks!

On Thu, Mar 21, 2019 at 5:28 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

My pull request(https://github.com/EnterpriseDB/wcDocker/pull/5) to fix resize issue in wcDocker is merged. Attached patch will update the version of wcDocker and fix the issue in pgAdmin4.
Do not forget to yarn install.

Kindly review.


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)

От
Aditya Toshniwal
Дата:
Hi,

On Thu, Mar 21, 2019 at 3:08 PM Dave Page <dpage@pgadmin.org> wrote:


On Thu, Mar 21, 2019 at 9:24 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

On Thu, Mar 21, 2019 at 2:51 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

Do we still need our fork of wcDocker?
Yes we do. pgAdmin depends on changes done on forked wcDocker. 

Also, please let me know when you're running low on things to do in this sprint (not including schema diff). I have one other issue I'd like to get worked on ASAP.
Yeah, please let me know. I am available. 


I'd like to discuss first though - are you available in the next 5 or 10 minutes
Will be available after 30 mins (have meeting) :/
 

Thanks!

On Thu, Mar 21, 2019 at 5:28 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi Hackers,

My pull request(https://github.com/EnterpriseDB/wcDocker/pull/5) to fix resize issue in wcDocker is merged. Attached patch will update the version of wcDocker and fix the issue in pgAdmin4.
Do not forget to yarn install.

Kindly review.


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"

Re: [pgAdmin4][RM3968] Panel automatically gets resized (wcDocker)

От
Dave Page
Дата:


On Thu, Mar 21, 2019 at 9:41 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

On Thu, Mar 21, 2019 at 3:08 PM Dave Page <dpage@pgadmin.org> wrote:


On Thu, Mar 21, 2019 at 9:24 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

On Thu, Mar 21, 2019 at 2:51 PM Dave Page <dpage@pgadmin.org> wrote:
Thanks, applied.

Do we still need our fork of wcDocker?
Yes we do. pgAdmin depends on changes done on forked wcDocker. 

Also, please let me know when you're running low on things to do in this sprint (not including schema diff). I have one other issue I'd like to get worked on ASAP.
Yeah, please let me know. I am available. 


I'd like to discuss first though - are you available in the next 5 or 10 minutes
Will be available after 30 mins (have meeting) :/

Just realised so do I. I'll ping you... 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company